Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: request access via duos in addition to dbgap (#4127) #4362

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat: request access via duos in addition to dbgap (#4127) #4362

merged 1 commit into from
Feb 4, 2025

Conversation

frano-m
Copy link
Contributor

@frano-m frano-m commented Feb 4, 2025 •
edited
Loading

Ticket

Closes #4127.

Reviewers

@NoopDog.

Changes

  • Added "DUOS" to request access in addition to dbGaP as per mock.
image

Definition of Done (from ticket)

  • Duos Only: display the "Request Access" button with no menu.
  • dbGaP Only: display the "Request Access" button with no menu.
  • Duos and dbGaP: display the "Request Access" button with menu display Duos and dbGaP options.

@github-actions github-actions bot added the canary Done by the Clever Canary team label Feb 4, 2025
MillenniumFalconMechanic
MillenniumFalconMechanic approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks F!

@NoopDog NoopDog merged commit 97b8cdb into main Feb 4, 2025
4 checks passed
@NoopDog NoopDog mentioned this pull request Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MillenniumFalconMechanic MillenniumFalconMechanic MillenniumFalconMechanic approved these changes

@NoopDog NoopDog Awaiting requested review from NoopDog

Assignees

@NoopDog NoopDog

Labels
canary Done by the Clever Canary team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request access via DUOS in addition to dbGaP
3 participants
@frano-m @MillenniumFalconMechanic @NoopDog