Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link component internal url test should include hash routes #147

Closed
frano-m opened this issue Aug 5, 2024 · 0 comments · Fixed by #148
Closed

Link component internal url test should include hash routes #147

frano-m opened this issue Aug 5, 2024 · 0 comments · Fixed by #148
Assignees
@frano-m

Comments

@frano-m
Copy link
Contributor

frano-m commented Aug 5, 2024 •
edited
Loading

The Link component should be able to handle hash routes e.g. #my-internal-hash-link.

The Link component should also be able to take additional link related props like id.
@frano-m frano-m self-assigned this Aug 5, 2024
frano-m pushed a commit that referenced this issue Aug 5, 2024
feat: link component internal url test should include hash routes (#147)
bbbe7e3
@frano-m frano-m mentioned this issue Aug 5, 2024
Merged
frano-m pushed a commit that referenced this issue Aug 6, 2024
feat: link component internal url test should include hash routes (#147)
ee1ccc6
frano-m pushed a commit that referenced this issue Aug 7, 2024
feat: link component internal url test should include hash routes (#147)
2ec1c7b
NoopDog pushed a commit that referenced this issue Aug 7, 2024
@frano-m
feat: link component internal url test should include hash routes (#147…
a797199 
…) (#148)

Co-authored-by: Fran McDade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frano-m frano-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: link component internal url test should include hash routes (#147) DataBiosphere/findable-ui
1 participant
@frano-m