Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filter UI and have state #165

Closed
MillenniumFalconMechanic opened this issue Aug 14, 2024 · 0 comments · Fixed by #176
Closed

Update filter UI and have state #165

MillenniumFalconMechanic opened this issue Aug 14, 2024 · 0 comments · Fixed by #176
Assignees
@NoopDog @frano-m

Comments

@MillenniumFalconMechanic
Copy link
Collaborator

MillenniumFalconMechanic commented Aug 14, 2024 •
edited
Loading

See Figma.

image

From K:

I wasn't satisfied with how the filter update turned out. I don't like that there is so much emphasis on section headings, and the facets look kind of inactive/disabled.

If you didn't notice, I tried to flip the script for AnVIL and added a hover state. Personally, I think this is a better approach: https://www.figma.com/design/JOUDXkKfgivRNFdBsWDPEH/AnVIL?node-id=7353-10411&t=1bbK9IcF987gvg0Y-1
frano-m pushed a commit that referenced this issue Aug 26, 2024
feat: update filter ui and hover state (#165)
5f7926a
@frano-m frano-m mentioned this issue Aug 26, 2024
Merged
frano-m pushed a commit that referenced this issue Aug 26, 2024
feat: update filter ui and hover state (#165)
01ed245
frano-m pushed a commit that referenced this issue Aug 26, 2024
feat: updated filter tag and filter popover position (#165)
a76e002
NoopDog pushed a commit that referenced this issue Aug 26, 2024
@frano-m
feat: update filter ui and hover state (#165) (#176)
1245e08 
* feat: update filter ui and hover state (#165)

* feat: updated filter tag and filter popover position (#165)

---------

Co-authored-by: Fran McDade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoopDog NoopDog

@frano-m frano-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update filter ui and hover state (#165) DataBiosphere/findable-ui
3 participants
@MillenniumFalconMechanic @NoopDog @frano-m