Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix centre alignment of version info component and update Config Provider to optionally receive the entity list #275

Closed
frano-m opened this issue Nov 20, 2024 · 0 comments · Fixed by #276
Closed

Fix centre alignment of version info component and update Config Provider to optionally receive the entity list #275

frano-m opened this issue Nov 20, 2024 · 0 comments · Fixed by #276
Assignees
@NoopDog @frano-m

Comments

@frano-m
Copy link
Contributor

frano-m commented Nov 20, 2024 •
edited
Loading

Config Provider

Update the config provider to return a default entity configuration, if the entities are [] and no entity list is defined.

Version Info

The RHS of the footer may sometimes have more than just links i.e. socials. We should centre align the chip always, in anticipation of this variation.

See LungMAP footer implementation.
@frano-m frano-m self-assigned this Nov 20, 2024
@frano-m frano-m changed the title Fix centre alignment of version info component Fix centre alignment of version info component and update Config Provider to optionally receive the entity list Nov 20, 2024
frano-m pushed a commit that referenced this issue Nov 20, 2024
fix: centre alignment of version info and update Config Provider enti…
408b2ac 
…ty list as optional (#275)
@frano-m frano-m mentioned this issue Nov 20, 2024
Merged
NoopDog pushed a commit that referenced this issue Nov 20, 2024
@frano-m
fix: centre alignment of version info and update Config Provider enti…
4234063 
…ty list as optional (#275) (#276)

Co-authored-by: Fran McDade <[email protected]>
@github-actions github-actions bot mentioned this issue Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoopDog NoopDog

@frano-m frano-m

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NoopDog @frano-m