Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade package versions to enable install without package lock (#192) #193

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

hunterckx
Copy link
Contributor

@hunterckx hunterckx commented Sep 5, 2024

Notes:

  • I tried using this with BRC, and it worked for the most part, but required some changes to the app -- mainly updating package versions there, but also some type issues relating to the theme that I'm not certain how to properly fix
  • The sort order for imports that's enforced by prettier-plugin-organize-imports has changed (I think this is part of Typescript?), so I've run Prettier to update the affected files

@hunterckx hunterckx marked this pull request as ready for review September 6, 2024 00:15
Copy link
Contributor

@frano-m frano-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀 @hunterckx thank you!

Copy link
Collaborator

@NoopDog NoopDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @frano-m @hunterckx !

@NoopDog NoopDog merged commit 89ae55b into main Sep 9, 2024
2 checks passed
@NoopDog NoopDog deleted the hunter/192-fix-install branch October 16, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants