Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added optional id to ExportMethod buttons (#217) #220

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Oct 15, 2024

Need

Track clicks to the ExportMethod buttons, with different events depending on the button

Approach

  • Added an optional prop to ExportMethod add a id for tracking purposes
  • Added the tracking id to the invocation of ExportButton in ExportMethod

@jpaten jpaten requested a review from frano-m October 15, 2024 01:27
@jpaten jpaten linked an issue Oct 15, 2024 that may be closed by this pull request
@frano-m frano-m force-pushed the jonah/217-add-id-to-exportmethod-buttons branch from 26e9192 to 326bfbc Compare October 16, 2024 23:12
Copy link
Contributor

@frano-m frano-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks @jpaten

@frano-m frano-m merged commit e3de566 into main Oct 16, 2024
2 checks passed
@frano-m frano-m deleted the jonah/217-add-id-to-exportmethod-buttons branch October 16, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GA4 tracking to exportMethod buttons
2 participants