Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added and updated index export tracking (#222) #224

Merged
merged 2 commits into from
Oct 30, 2024
Merged

feat: added and updated index export tracking (#222) #224

merged 2 commits into from
Oct 30, 2024

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Oct 17, 2024

  • Added event models as follows:
  • Add the following event models
    • index_analyze_in_terra_requested
      • entity_name
    • index_file_manifest_requested
      • entity_name
  • Alter the existing bulk_download_requested model as follows
    • Remove params for catalog and current_query
    • Rename index to entity_name
  • Called events on clicking the request button
  • Documented changes in readme-analytics.md

@jpaten jpaten linked an issue Oct 17, 2024 that may be closed by this pull request
Add/Update GA4 tracking for DownloadCurlCommand, ExportToTerra, and ManifestDownload #222
Closed
@NoopDog
Copy link
Collaborator

NoopDog commented Oct 17, 2024

Hi @jpaten is this still meant to be in WIP or is it ready to review? Thx!

@jpaten jpaten marked this pull request as ready for review October 17, 2024 20:28
@jpaten jpaten marked this pull request as draft October 17, 2024 20:28
@MillenniumFalconMechanic
Copy link
Collaborator

Hi @jpaten, naming conventions here LGTM. Thank you! cc @NoopDog.

MillenniumFalconMechanic
MillenniumFalconMechanic requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jpaten, looks good! Just added a couple of nits.

src/components/Export/common/tracking.ts Outdated
Comment on lines 22 to 23
console.log("tracking file manifest requested event");
console.log(entity_name);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log's!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! So sorry about that!

src/components/Export/common/tracking.ts Show resolved Hide resolved
@jpaten jpaten force-pushed the jonah/222-backpage-export-events branch from d0732f1 to d1687b0 Compare October 25, 2024 02:14
@jpaten jpaten marked this pull request as ready for review October 25, 2024 05:34
@jpaten
Copy link
Contributor Author

jpaten commented Oct 25, 2024

@MillenniumFalconMechanic sorry about those errors, I've updated the PR as suggested!

@jpaten jpaten mentioned this pull request Oct 25, 2024
Closed
11 tasks
MillenniumFalconMechanic
MillenniumFalconMechanic approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jonah!

@jpaten jpaten force-pushed the jonah/222-backpage-export-events branch from d1687b0 to d8c8571 Compare October 30, 2024 00:17
@NoopDog NoopDog merged commit 15e861d into main Oct 30, 2024
2 checks passed
@NoopDog NoopDog mentioned this pull request Oct 29, 2024
Merged
frano-m pushed a commit that referenced this pull request Nov 1, 2024
@jpaten
feat: added and updated index export tracking (#222) (#224)
202dd69 
* feat: added and updated index export tracking (#222)

* chore: added tsdocs (#222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MillenniumFalconMechanic MillenniumFalconMechanic MillenniumFalconMechanic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/Update GA4 tracking for DownloadCurlCommand, ExportToTerra, and ManifestDownload
3 participants
@jpaten @NoopDog @MillenniumFalconMechanic