fix!: ensure select category value label is string and type key as unknown (#298) #299
+33
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterckx
commented
Dec 17, 2024
hunterckx
changed the title
frano-m
reviewed
Dec 18, 2024
frano-m
reviewed
Dec 18, 2024
frano-m
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Nice @hunterckx. Approved.
I have one question for you (just a sanity check).
I will write up a ticket for updating AzulTerm interface term. We currently also get null values. We should probably address this for correctness - in the filterTransformer and also in the File Manifest facets.
NoopDog
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've marked this as a breaking change because theoretically an app might reference filter items in a way that causes type errors;
data-browser, for instance, almost does this, but the values are passed tosanitizeString, which I've updated the type of to make it still work there