Log deprecation message for recipes using easy_install. #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
reviewed
Mar 6, 2019
recipes/ddtrace-python.rb
Outdated
| @@ -6,6 +6,11 @@ | |||
| # NB: This recipe is compatible with Chef <= 12 only. If you're using Chef 13 or higher | |||
| # please refer to the README of the cookbook. | |||
|
|
|||
| log 'message' do | |||
| message 'This recipe will be deprecated in version 3.0.0 of the cookbook. See README.md chapter ddtrace-python for more infos.' | |||
There was a problem hiding this comment.
chapter -> section
infos -> info
Also, can you remind the name of the cookbook in the message? (datadog cookbook). Generally useful.
There was a problem hiding this comment.
thanks 👍
I've also repeated the recipe name.
recipes/ddtrace-python.rb
Outdated
| @@ -6,6 +6,11 @@ | |||
| # NB: This recipe is compatible with Chef <= 12 only. If you're using Chef 13 or higher | |||
| # please refer to the README of the cookbook. | |||
|
|
|||
| log 'message' do | |||
There was a problem hiding this comment.
any reason to use the resource instead of Chef::Log? (genuine question, didn't know about the resource)
There was a problem hiding this comment.
Not any, I've changed to use Chef::Log as I see there is already many usage of it in the repo, I prefer to stick with known things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.