Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.52.x] pkg/trace/api: limit simultaneous otlp requests, do not drop payloads #23151

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

Backport a396d12 from #23085.

…#23085)

pkg/trace/api: limit simultaneous otlp requests, do not drop payloads

Co-authored-by: dineshg13 <[email protected]>
(cherry picked from commit a396d12)
@agent-platform-auto-pr agent-platform-auto-pr bot requested review from a team as code owners February 26, 2024 16:36
@agent-platform-auto-pr agent-platform-auto-pr bot requested review from songy23 and removed request for a team February 26, 2024 16:36
@knusbaum knusbaum added team/agent-apm trace-agent team/opentelemetry OpenTelemetry team labels Feb 26, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2024

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: e8a2adfd-7eaf-429f-bece-e1827b8fe047
Baseline: 36d7ecd
Comparison: 2ed261f
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.77 [-7.29, +5.75]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +1.21 [+1.15, +1.28]
process_agent_standard_check memory utilization +0.91 [+0.86, +0.96]
uds_dogstatsd_to_api_cpu % cpu utilization +0.85 [-0.57, +2.26]
process_agent_real_time_mode memory utilization +0.68 [+0.64, +0.73]
file_tree memory utilization +0.20 [+0.09, +0.31]
otel_to_otel_logs ingress throughput +0.16 [-0.47, +0.80]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.04, +0.02]
trace_agent_msgpack ingress throughput -0.01 [-0.02, +0.01]
process_agent_standard_check_with_stats memory utilization -0.05 [-0.09, +0.00]
idle memory utilization -0.29 [-0.34, -0.24]
file_to_blackhole % cpu utilization -0.77 [-7.29, +5.75]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@kacper-murzyn
Copy link
Collaborator

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 27, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 47m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 999b4e6 into 7.52.x Feb 27, 2024
183 of 186 checks passed
@dd-mergequeue dd-mergequeue bot deleted the backport-23085-to-7.52.x branch February 27, 2024 08:51
@github-actions github-actions bot added this to the 7.52.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants