Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix bad citizens detection #3020

Merged
merged 2 commits into from
Nov 10, 2016
Merged

[ci] fix bad citizens detection #3020

merged 2 commits into from
Nov 10, 2016

Conversation

degemer
Copy link
Member

@degemer degemer commented Nov 10, 2016

[ci] fix bad citizens detection

Ternary operation has a high priority in Ruby.
Also add a short comment about the meaning of the bad citizens.

@degemer degemer changed the title THIS IS A DEBUG [ci] fix bad citizens detection Nov 10, 2016
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Ternary operation has a high priority in Ruby.
Also add a short comment about the meaning of the bad citizens.
Check name and Travis check are the same.
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@degemer degemer merged commit 1bd73c9 into master Nov 10, 2016
@degemer degemer deleted the quentin/ci-debug branch November 10, 2016 23:43
degemer added a commit that referenced this pull request Nov 15, 2016
* master: (254 commits)
  Reduce the maximum amount of argument to pylint.
  [forwarder] stop flushing after 10s
  [etcd] Report errors connecting to etcd endpoint (#3007)
  Postfix check should pass raise_on_empty_output=False
  [status] Silence requests exception
  [psutil] Only set `psutil.PROCFS_PATH` once in the collector (#3013)
  [ci] fix check name detection of test files (#3021)
  [ci][rabbitmq] Increase wait timeout (#3022)
  [core] SpooledTemporaryFile for subprocess output (#3002)
  [collector] isolate system checks (#3001)
  [ci] Fix Travis jobs timing out (#3017)
  [mongo] Use db.current_op instead of manually querying (#3016)
  [ci] fix bad citizens detection (#3020)
  [ci] add debug logs (#3019)
  [mongo] use `currentOp` for mongodb 3.2+
  Use proxy for API key check in info page (#3012)
  [mongo] Add MongoDB 3.2 support
  [mongo] Add MongoDB 3.2 to travis-ci config
  [packaging] 5.11.0 nightlies (#3009)
  [core] hard-deprecate start/stop/restart/status (#3004)
  ...
truthbk pushed a commit that referenced this pull request Nov 16, 2016
* [ci] fix bad citizens detection

Ternary operation has a high priority in Ruby.
Also add a short comment about the meaning of the bad citizens.

* [ci] mongo is a good citizen

Check name and Travis check are the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants