RUM-2925 CR feedback

DataDog · Feb 21, 2024 · 97f4286 · 97f4286
1 parent a091990
commit 97f4286
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/Datadog/IntegrationUnitTests/RUM/AppHangsMonitoringTests.swift b/Datadog/IntegrationUnitTests/RUM/AppHangsMonitoringTests.swift
@@ -14,14 +14,12 @@ class AppHangsMonitoringTests: XCTestCase {
     private var rumConfig = RUM.Configuration(applicationID: .mockAny())
 
     override func setUp() {
-        super.setUp()
         core = DatadogCoreProxy()
     }
 
     override func tearDown() {
         core.flushAndTearDown()
         core = nil
-        super.tearDown()
     }
 
     func testWhenMainThreadHangsAboveThreshold_itTracksAppHang() throws {

diff --git a/DatadogRUM/Sources/Instrumentation/AppHangs/AppHangsWatchdogThread.swift b/DatadogRUM/Sources/Instrumentation/AppHangs/AppHangsWatchdogThread.swift
@@ -16,7 +16,7 @@ internal struct AppHang {
 }
 
 internal final class AppHangsWatchdogThread: Thread {
-    struct Constants {
+    enum Constants {
         /// The "idle" interval for sleeping the watchdog thread before scheduling the next task on the main queue, represented as a percentage of the `appHangThreshold`.
         ///
         /// Introducing even a small sleep significantly reduces CPU consumption by the watchdog thread (nearly 0%). No sleep would result in close to 100% CPU usage.
@@ -114,7 +114,7 @@ internal final class AppHangsWatchdogThread: Thread {
                 // If the hang duration is irrealistically long (way more than assumed iOS watchdog termination limit: ~10s), send telemetry.
                 // This could be another false-positive caused by thread suspension between the two `wait()` calls.
                 telemetry.debug("Detected an App Hang with an unusually long duration", attributes: ["hang_duration": hangDuration])
-                return
+                continue
             }
 
             let appHang = AppHang(