Warn when DDNoopRUMMonitor is sent any DDRUMMonitor methods #1007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR resolves the baseline request in #978 by calling
warn()
when any method vended byDDRUMMonitor
is called on an instance ofDDNoopRUMMonitor
.This change will make it more obvious when a
DDNoopRUMMonitor
has been captured and is being utilized accidentally.How?
I copied over all methods from
DDRUMMonitor
intoDDNoopRUMMonitor
, replacedpublic
withoverride
, and calledwarn()
within each method body.Review checklist
Custom CI job configuration (optional)