Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release/1.13.0 to develop #1042

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Merge release/1.13.0 to develop #1042

merged 6 commits into from
Nov 9, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Nov 7, 2022

What and why?

git-flow: counterpart of #1041

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maxep maxep self-assigned this Nov 7, 2022
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 7, 2022 •
edited
Loading

Datadog Report

Branch report: release/1.13.0
Commit report: 53d6322

❄️ dd-sdk-ios 0 Failed, 1 New Flaky, 1903 Passed, 0 Skipped, 5m 46.23s Wall Time

New Flaky Tests (1)

  • testStartingView_thenTappingButton_thenTappingAnotherButton - RUMMonitorTests - Last Failure

    Expand for error 
     Assertion Failure at RUMMonitorTests.swift:657: XCTAssertEqual failed: ("2") is not equal to ("3")

@maxep maxep marked this pull request as ready for review November 8, 2022 14:31
@maxep maxep requested a review from a team as a code owner November 8, 2022 14:31
@ncreated ncreated merged commit e34d9e6 into develop Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees

@maxep maxep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxep @ncreated