Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not embed DatadogInternal while building Trace and RUM xcframeworks #1444

Merged
merged 2 commits into from
Aug 29, 2023
Merged

fix: do not embed DatadogInternal while building Trace and RUM xcframeworks #1444

merged 2 commits into from
Aug 29, 2023

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Aug 29, 2023 •
edited
Loading

What and why?

Fixes #1443

How?

A brief description of implementation details of this PR.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@ganeshnj ganeshnj force-pushed the ganeshnj/fix/gh-1443-do-not-embed branch from 1b28b2e to 2179f7e Compare August 29, 2023 12:58
@ganeshnj ganeshnj marked this pull request as ready for review August 29, 2023 13:01
@ganeshnj ganeshnj requested a review from a team as a code owner August 29, 2023 13:01
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Aug 29, 2023 •
edited
Loading

Datadog Report

Branch report: ganeshnj/fix/gh-1443-do-not-embed
Commit report: b67b363

✅ dd-sdk-ios: 0 Failed, 0 New Flaky, 158 Passed, 0 Skipped, 16m 53.74s Wall Time

@ganeshnj ganeshnj changed the base branch from develop to hotfix/2.1.2 August 29, 2023 13:40
@ganeshnj ganeshnj force-pushed the ganeshnj/fix/gh-1443-do-not-embed branch from 2179f7e to b67b363 Compare August 29, 2023 13:41
@ganeshnj ganeshnj merged commit 36406af into hotfix/2.1.2 Aug 29, 2023
18 checks passed
@ganeshnj ganeshnj mentioned this pull request Aug 29, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

@maxep maxep maxep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appstore upload failure
3 participants
@ganeshnj @maxep @maciejburda