New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default objc rum predicates #1464

Merged

maciejburda merged 3 commits into release/2.2.1 from maciey/fix-objc-rum-predicates

Sep 13, 2023

Member

maciejburda commented Sep 12, 2023

What and why?

Adds missing default objective-c predicates, which are part of official documentation:
https://docs.datadoghq.com/real_user_monitoring/ios/?tab=objectivec#initialize-the-rum-monitor-and-ddurlsessiondelegate

Review checklist

Feature or bugfix MUST have appropriate tests (unit, integration)
Make sure each commit and the PR mention the Issue number or JIRA reference
Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

Run unit tests
Run integration tests
Run smoke tests

maciejburda added 2 commits

September 12, 2023 17:05


          Add missing default predicates

3d528c5


          Add tests

ec596d9

maciejburda requested a review from a team as a code owner

September 12, 2023 16:57


          Update CHANGELOG.md

datadog-datadog-prod-us1 bot commented Sep 12, 2023 •

edited

Loading

Datadog Report

Branch report: maciey/fix-objc-rum-predicates
Commit report: 1084240

✅ dd-sdk-ios: 0 Failed, 0 New Flaky, 118 Passed, 0 Skipped, 2m 12.75s Wall Time

maxep approved these changes

View reviewed changes

Member

maxep left a comment

Thank you 🙏

maciejburda merged commit ef98671 into release/2.2.1

5 checks passed

maciejburda deleted the maciey/fix-objc-rum-predicates branch

September 13, 2023 08:15

This was referenced Sep 13, 2023

Release 2.2.1 #1466

Closed

Release 2.2.1 #1471

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet