Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove modulemap #1746

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Remove modulemap #1746

merged 1 commit into from
Mar 29, 2024

Conversation

maciejburda
Copy link
Member

@maciejburda maciejburda commented Mar 25, 2024 •
edited
Loading

What and why?

Removes Datadog.modulemap as it's unnecessary with new versions of Xcode.

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maciejburda maciejburda marked this pull request as ready for review March 25, 2024 13:14
@maciejburda maciejburda requested review from a team as code owners March 25, 2024 13:14
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 25, 2024 •
edited
Loading

Datadog Report

Branch report: maciey/remove-modulemap
Commit report: 6712747
Test service: dd-sdk-ios

✅ 0 Failed, 2944 Passed, 0 Skipped, 29m 19.16s Wall Time
🔻 Test Sessions change in coverage: 12 decreased, 3 increased

🔻 Code Coverage Decreases vs Default Branch (12)

This report shows up to 5 code coverage decreases.

  • test SRSnapshotTests 33.1% (-0.51%) - Details
  • test DatadogInternalTests iOS 79.4% (-0.36%) - Details
  • test DatadogInternalTests tvOS 79.4% (-0.31%) - Details
  • test DatadogTraceTests tvOS 49.46% (-0.28%) - Details
  • test DatadogLogsTests iOS 45.69% (-0.25%) - Details

@maciejburda
Copy link
Member Author

Tested using swift package init on Xcode 14.3.1 (14E300c).

No warning

@maxep maxep mentioned this pull request Mar 29, 2024
Closed
8 tasks
@maxep maxep merged commit 91b12b5 into develop Mar 29, 2024
20 checks passed
@maxep maxep deleted the maciey/remove-modulemap branch March 29, 2024 09:57
@maxep maxep mentioned this pull request Mar 29, 2024
Closed
@maxep maxep mentioned this pull request Apr 10, 2024
Merged
8 tasks
@ncreated ncreated mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejburda @maxep