Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2813 Add webview replay configuration #1754

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Mar 29, 2024

What and why?

Add SessionReplayConfiguration to web-view tracking.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep requested review from a team as code owners March 29, 2024 14:36
@maxep maxep force-pushed the maxep/RUM-2813/sr-webview-privacy branch from 98c6a26 to 819b4dd Compare March 29, 2024 14:40
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 29, 2024

Datadog Report

Branch report: maxep/RUM-2813/sr-webview-privacy
Commit report: 92dc3b0
Test service: dd-sdk-ios

✅ 0 Failed, 2835 Passed, 0 Skipped, 11m 53.75s Wall Time
❄️ 1 New Flaky
🔻 Test Sessions change in coverage: 2 decreased, 12 increased

New Flaky Tests (1)

  • testGivenRUMContextAvailable_whenReceivingWebEvent_itGetsEnrichedWithOtherMobileContextAndWritten - WebViewEventReceiverTests - Last Failure

    Expand for error
     Assertion Failure at WebViewEventReceiverTests.swift:228: failed - ("{
       "_dd" : {
         "browser_sdk_version" : "5.2.0",
         "session" : {
           "plan" : 1
         }
       },
       "absent-attribute" : null,
       "application" : {
         "id" : "pacbQBWCdB"
     ...
    

🔻 Code Coverage Decreases vs Default Branch (2)

  • test DatadogCoreTests iOS 73.25% (-0.7%) - Details
  • test DatadogCoreTests tvOS 79.92% (-0.34%) - Details

@maxep maxep self-assigned this Apr 4, 2024
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. I left few non-blocking suggestions.

DatadogWebViewTracking/Sources/WebViewTracking.swift Outdated Show resolved Hide resolved
DatadogWebViewTracking/Sources/WebViewTracking.swift Outdated Show resolved Hide resolved
DatadogWebViewTracking/Sources/WebViewTracking.swift Outdated Show resolved Hide resolved
DatadogWebViewTracking/Sources/WebViewTracking.swift Outdated Show resolved Hide resolved
DatadogWebViewTracking/Sources/WebViewTracking.swift Outdated Show resolved Hide resolved
@maxep maxep merged commit 6c4d5d1 into feature/webview-replay Apr 9, 2024
8 checks passed
@maxep maxep deleted the maxep/RUM-2813/sr-webview-privacy branch April 9, 2024 14:41
@maxep maxep mentioned this pull request Apr 15, 2024
8 tasks
@maciejburda maciejburda mentioned this pull request May 7, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants