Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release/2.9.0 to develop #1770

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Merge release/2.9.0 to develop #1770

merged 3 commits into from
Apr 11, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Apr 10, 2024

What and why?

git-flow counterpart of #1769

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 10, 2024 •
edited
Loading

Datadog Report

Branch report: release/2.9.0
Commit report: 290ed6c
Test service: dd-sdk-ios

✅ 0 Failed, 3029 Passed, 0 Skipped, 29m 6.93s Wall Time
🔻 Test Sessions change in coverage: 10 decreased, 4 increased, 1 no change

🔻 Code Coverage Decreases vs Default Branch (10)

This report shows up to 5 code coverage decreases.

  • test DatadogCrashReportingTests iOS 27.87% (-0.69%) - Details
  • test DatadogWebViewTrackingTests iOS 17.13% (-0.68%) - Details
  • test DatadogCrashReportingTests tvOS 27.93% (-0.67%) - Details
  • test DatadogTraceTests iOS 48.76% (-0.43%) - Details
  • test DatadogTraceTests tvOS 48.83% (-0.41%) - Details

ncreated
ncreated reviewed Apr 10, 2024
View reviewed changes
CHANGELOG.md
Comment on lines +8 to +9
* [FIX] Remove modulemap. See [#1746][]
* [FIX] Expose objc interfaces in Session Replay module. See [#1697][]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

ncreated
ncreated previously approved these changes Apr 10, 2024
View reviewed changes
@maxep maxep mentioned this pull request Apr 11, 2024
Merged
8 tasks
@maxep maxep marked this pull request as ready for review April 11, 2024 11:33
@maxep maxep requested review from a team as code owners April 11, 2024 11:33
@maxep maxep requested a review from ncreated April 11, 2024 12:02
@maxep maxep merged commit e4daf54 into develop Apr 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxep @ncreated