Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-9813] Fix for test sdk integration #1852

Merged
merged 1 commit into from
May 22, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented May 20, 2024

What and why?

📦 Re-attempt on #1833 after fixing linter and bumping swiftlint in #1850

From original PR:

Swift testing library is using MachPorts to communicate with this library. They are unique for OS kernel, so each process should have a unique name for them. Right now we are using hardcoded names, so two running test processes will fail.

How?

Testing library sets CI_VISIBILITY_MESSAGE_CHANNEL_UUID variable which is used for name generation for MachPorts.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this May 20, 2024
@ncreated ncreated requested review from a team as code owners May 20, 2024 09:26
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 20, 2024

Datadog Report

Branch report: ncreated/chore/fix-integration-with-swift-testing
Commit report: 137c015
Test service: dd-sdk-ios

✅ 0 Failed, 2897 Passed, 0 Skipped, 2m 10.56s Total Time
🔻 Test Sessions change in coverage: 6 decreased, 2 increased, 5 no change

🔻 Code Coverage Decreases vs Default Branch (6)

This report shows up to 5 code coverage decreases.

  • test DatadogCoreTests iOS 73.15% (-0.11%) - Details
  • test DatadogCrashReportingTests tvOS 27.64% (-0.07%) - Details
  • test DatadogCrashReportingTests iOS 27.61% (-0.05%) - Details
  • test DatadogTraceTests tvOS 55.59% (-0.04%) - Details
  • test DatadogCoreTests tvOS 78.72% (-0.04%) - Details

@ncreated ncreated changed the title [CIVIS-9813] fix for test sdk integration [CIVIS-9813] Fix for test sdk integration May 20, 2024
@ncreated ncreated merged commit cf4ddc5 into develop May 22, 2024
11 checks passed
@ncreated ncreated deleted the ncreated/chore/fix-integration-with-swift-testing branch May 22, 2024 08:11
This was referenced May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants