Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogfood recent changes (retry) #1870

Merged
merged 5 commits into from
May 29, 2024
Merged

Dogfood recent changes (retry) #1870

merged 5 commits into from
May 29, 2024

Conversation

ncreated
Copy link
Member

What and why?

Previous dogfooding attempt (#1865) failed due to #1869

This PR restarts the process after fix. Ultimately, we will be dogfooding:

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated requested review from a team as code owners May 29, 2024 15:44
@ncreated ncreated self-assigned this May 29, 2024
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: develop
Commit report: 13b1a07
Test service: dd-sdk-ios

✅ 0 Failed, 253 Passed, 0 Skipped, 9.92s Total Time

Comment on lines +539 to +549
- script:
title: Smoke test dogfooding (with dry-run)
run_if: '{{enveq "DD_RUN_TOOLS_TESTS" "1"}}'
inputs:
- content: |-
#!/usr/bin/env bash
set -e

export DD_DRY_RUN=yes
cd tools/distribution && make
venv/bin/python3 dogfood.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ncreated ncreated merged commit 9030adb into dogfooding May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants