Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5174 Fix attribute casting for objc interop #1947

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Jul 8, 2024

What and why?

KMP support: attempt to cast cross-platform attributes when reading values.

Target: 2.14.1 hotfix

How?

ObjC interoperability of attributes is now exposed in DatadogInternal module using DatadogExtension protocol. All feature can now use the .dd.decode() method to read cross-platform attributes and cast them appropriately.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay

@maxep maxep requested review from a team as code owners July 8, 2024 11:58
@maxep maxep requested a review from 0xnm July 8, 2024 11:58
@maxep maxep changed the title Merge pull request #1808 from DataDog/release/2.11.0 RUM-5174 Fix attribute casting for objc interop Jul 8, 2024
@maxep maxep merged commit 212c669 into hotfix/2.14.1 Jul 9, 2024
16 checks passed
@maxep maxep deleted the maxep/kmp-objc-swift-interop branch July 9, 2024 08:07
This was referenced Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants