Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5716 fix: propagate global Tracer tags to otel span attributes #2000

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Aug 19, 2024

What and why?

Currently global tags are not included in the otel spans

How?

  • add global tags to the span first
  • add local tags to the span, and if there is same key, then replace it

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@ganeshnj ganeshnj requested review from a team as code owners August 19, 2024 09:45
ncreated
ncreated previously approved these changes Aug 20, 2024
ncreated
ncreated previously approved these changes Aug 21, 2024
@ganeshnj ganeshnj merged commit 07953e3 into develop Aug 21, 2024
16 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/feat/otel-tracer-tag branch August 21, 2024 11:45
@mariedm mariedm mentioned this pull request Sep 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants