RUM-5841 feat(view-loading-api): implement addViewLoadingTime API #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshnj
force-pushed
the
ganeshnj/feat/view-loading-api
branch
from
c6f8f1e to
ac3c881
Compare
ganeshnj
force-pushed
the
ganeshnj/feat/view-loading-api
branch
from
ac3c881 to
e49d5f0
Compare
Datadog ReportBranch report: ✅ 0 Failed, 1869 Passed, 0 Skipped, 1m 15.03s Total Time 🔻 Code Coverage Decreases vs Default Branch (3) |
ncreated
previously approved these changes
Aug 28, 2024
Co-authored-by: Maciek Grzybowski <[email protected]>
Co-authored-by: Maciek Grzybowski <[email protected]>
ncreated
approved these changes
Aug 30, 2024
|
Since this was linked in the latest release: Is there any public documentation on how to use this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
https://datadoghq.atlassian.net/wiki/spaces/RUMP/pages/3951001790/RFC+View+loading+time+manual+API
How?
This PR follows the RFC and introduces
addViewLoadingTimeAPI. The implementation follows the existing command pattern and updates theRUMViewEvent.view.loadingwhen called which also triggers the view update.This PR doesn't introduce any telemetry which will be added in upcoming PRs. We will require #2019 to merged as prerequisite.
Review checklist