-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-5992 Support additional properties mutation #2099
Conversation
3633c04
to
d18f061
Compare
ffc0112
to
d7b946d
Compare
@@ -504,3 +506,55 @@ extension SwiftPrinter.Configuration.AccessLevel: CustomStringConvertible { | |||
} | |||
} | |||
} | |||
|
|||
extension SwiftStruct.Property { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use backticks all the time? This way we don't have to update the list of reserved keywords.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be! Lets see if it becomes problematic, I don't expect much use of these keywords.
d7b946d
to
4db2118
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, the change is on target 🎯!
4db2118
to
04e8ef3
Compare
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
/remove |
🚂 Devflow: |
This merge request was unqueued If you need support, contact us on Slack #devflow! |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What and why?
Additional properties are generated with
internal(set)
accessor, preventing users from mutating their attributes using event mappers. These changes align with Android and allow additional properties mutation in both Swift and ObjC.How?
protocol
.Review checklist
make api-surface
)