Address review comments

DataDog · Jan 24, 2025 · 632d1dd · 632d1dd
1 parent b02fb2e
commit 632d1dd
Show file tree

Hide file tree

Showing 9 changed files with 30 additions and 32 deletions.
diff --git a/ivanti_connect_secure/README.md b/ivanti_connect_secure/README.md
@@ -17,12 +17,10 @@ Visualize detailed insights into these logs through the out-of-the-box dashboard
 
 ### Installation
 
-To install the Ivanti Connect Secure integration, run the following Agent installation command and the steps below. For more information, see the [Integration Management][4] documentation.
+To install the Ivanti Connect Secure integration, run the following Agent installation command in your terminal, then complete the configuration steps below. For more information, see the [Integration Management][4] documentation.
 
 **Note**: This step is not necessary for Agent version >= 7.59.0.
 
-Linux command
-
 ```shell
 sudo -u dd-agent -- datadog-agent integration install datadog-ivanti_connect_secure==1.0.0
 ```
@@ -31,7 +29,7 @@ sudo -u dd-agent -- datadog-agent integration install datadog-ivanti_connect_sec
 
 #### Log collection
 
-1. Collecting logs is disabled by default in the Datadog Agent. Enable it in the `datadog.yaml`:
+1. Collecting logs is disabled by default in the Datadog Agent. Enable it in `datadog.yaml`:
 
    ```yaml
    logs_enabled: true
@@ -43,7 +41,7 @@ sudo -u dd-agent -- datadog-agent integration install datadog-ivanti_connect_sec
 
    ```yaml
    logs:
-     - type: <tcp/udp>
+     - type: tcp # or 'udp'
        port: <PORT>
        source: ivanti-connect-secure
        service: ivanti-connect-secure
@@ -64,11 +62,11 @@ sudo -u dd-agent -- datadog-agent integration install datadog-ivanti_connect_sec
 4. Under **Select Events to Log**, ensure all event types are selected.
 5. Click **Save Changes** to apply the configuration.
 6. Configure the syslog server details in the **Syslog Servers** section:
-   - **Server name/IP**: Enter the fully qualified domain name or IP address of the syslog server in the format `<IP/domain>:<port>`.
-   - **Type**: Select either **TCP** or **UDP** from the dropdown
-   - **Filter**: Choose **JSON: JSON** from the dropdown
+   - **Server name/IP**: Enter the fully qualified domain name or IP address of the syslog server in the format `<IP/DOMAIN>:<PORT>`.
+   - **Type**: Select either **TCP** or **UDP** from the dropdown.
+   - **Filter**: Choose **JSON: JSON** from the dropdown.
      <br>After entering the required details, click **Add**.
-7. Repeat steps 3 to 6 for the **User Access** and **Admin Access** tabs.
+7. Repeat steps 3 to 6 in the **User Access** and **Admin Access** tabs.
 
 ### Validation
 

diff --git a/ivanti_connect_secure/assets/configuration/spec.yaml b/ivanti_connect_secure/assets/configuration/spec.yaml
@@ -4,7 +4,7 @@ files:
   options:
   - template: logs
     example:
-    - type: tcp/udp
+    - type: tcp # or 'udp'
       port: <PORT>
       source: ivanti-connect-secure
       service: ivanti-connect-secure
diff --git a/ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_administrator_activities.json b/ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_administrator_activities.json
@@ -25,7 +25,7 @@
             "id": 495983273354694,
             "definition": {
                 "type": "note",
-                "content": "This dashboard offers a centralized view of administrative activities, ensuring transparency and visibility into critical operations.\n\nIt enables compliance monitoring and detection of unauthorized actions to maintain system integrity. .\n \nFor more information, see the [Ivanti Connect Secure Integration Documentation](https://docs.datadoghq.com/integrations/ivanti_connect_secure).\n\n**Tips**\n- Use the timeframe selector in the upper-right corner of the dashboard to change the default timeframe.\n- Clone this dashboard to rearrange, modify, and add widgets and visualizations.",
+                "content": "This dashboard offers a centralized view of administrative activities, ensuring transparency and visibility into critical operations.\n\nIt enables compliance monitoring and detection of unauthorized actions to maintain system integrity.\n\nFor more information, see the [Ivanti Connect Secure Integration Documentation](https://docs.datadoghq.com/integrations/ivanti_connect_secure).\n\n**Tips**\n- Use the timeframe selector in the upper-right corner of the dashboard to change the default timeframe.\n- Clone this dashboard to rearrange, modify, and add widgets and visualizations.",
                 "background_color": "white",
                 "font_size": "14",
                 "text_align": "left",
@@ -105,7 +105,7 @@
                     {
                         "id": 7700611474623012,
                         "definition": {
-                            "title": "Failed Logins over time",
+                            "title": "Failed Logins over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -215,7 +215,7 @@
                     {
                         "id": 453951888890250,
                         "definition": {
-                            "title": "Successful Logins over time",
+                            "title": "Successful Logins over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,

diff --git a/ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_authentication.json b/ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_authentication.json
@@ -105,7 +105,7 @@
                     {
                         "id": 8702748035003160,
                         "definition": {
-                            "title": "Unauthenticated Web Requests over time",
+                            "title": "Unauthenticated Web Requests over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -422,7 +422,7 @@
                     {
                         "id": 4734511997755772,
                         "definition": {
-                            "title": "Failed Logins over time",
+                            "title": "Failed Logins over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -533,7 +533,7 @@
                     {
                         "id": 8921234832871242,
                         "definition": {
-                            "title": "Rejected Logins over time",
+                            "title": "Rejected Logins over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -644,7 +644,7 @@
                     {
                         "id": 4553625496347152,
                         "definition": {
-                            "title": "Successful Logins over time",
+                            "title": "Successful Logins over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,

diff --git a/..._connect_secure/assets/dashboards/ivanti_connect_secure_connection_and_vpn_tunneling.json b/..._connect_secure/assets/dashboards/ivanti_connect_secure_connection_and_vpn_tunneling.json
@@ -218,7 +218,7 @@
                     {
                         "id": 8979735835512980,
                         "definition": {
-                            "title": "Bytes Transferred over time",
+                            "title": "Bytes Transferred over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -506,7 +506,7 @@
                     {
                         "id": 6327435353768680,
                         "definition": {
-                            "title": "ACL Count over time",
+                            "title": "ACL Count over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -566,7 +566,7 @@
                     {
                         "id": 4054878727260096,
                         "definition": {
-                            "title": "Optimized ACL Count over time",
+                            "title": "Optimized ACL Count over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,

diff --git a/ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_overview.json b/ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_overview.json
@@ -106,7 +106,7 @@
                     {
                         "id": 8702748035003160,
                         "definition": {
-                            "title": "Logs by Severity over time",
+                            "title": "Logs by Severity over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -385,7 +385,7 @@
                     {
                         "id": 2570927267319314,
                         "definition": {
-                            "title": "Logs by Service over time",
+                            "title": "Logs by Service over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -873,7 +873,7 @@
                     {
                         "id": 5107853845773138,
                         "definition": {
-                            "title": "Count of Logs by User-Agents",
+                            "title": "Count of Logs by User-Agent",
                             "title_size": "16",
                             "title_align": "left",
                             "type": "toplist",

diff --git a/..._connect_secure/assets/dashboards/ivanti_connect_secure_statistics_and_system_status.json b/..._connect_secure/assets/dashboards/ivanti_connect_secure_statistics_and_system_status.json
@@ -54,7 +54,7 @@
                     {
                         "id": 8702748035003160,
                         "definition": {
-                            "title": "Concurrent logged in Users over time",
+                            "title": "Concurrent Logged-in Users over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -114,7 +114,7 @@
                     {
                         "id": 4562843163926840,
                         "definition": {
-                            "title": "NCP Connections over time",
+                            "title": "NCP Connections over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -174,7 +174,7 @@
                     {
                         "id": 8183349058937222,
                         "definition": {
-                            "title": "JCP Connection over time",
+                            "title": "JCP Connection over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -292,7 +292,7 @@
                     {
                         "id": 1997295212378182,
                         "definition": {
-                            "title": "Matched Files over time",
+                            "title": "Matched Files over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -352,7 +352,7 @@
                     {
                         "id": 6592991177188294,
                         "definition": {
-                            "title": "Detected Files over time",
+                            "title": "Detected Files over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -412,7 +412,7 @@
                     {
                         "id": 964190135913232,
                         "definition": {
-                            "title": "Mismatched Files over time",
+                            "title": "Mismatched Files over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,

diff --git a/ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_web_requests.json b/ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_web_requests.json
@@ -106,7 +106,7 @@
                     {
                         "id": 8702748035003160,
                         "definition": {
-                            "title": "Web Requests Logs over time",
+                            "title": "Web Requests Logs over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,
@@ -287,7 +287,7 @@
                     {
                         "id": 6775190727522570,
                         "definition": {
-                            "title": "Bytes Transferred over time",
+                            "title": "Bytes Transferred over Time",
                             "title_size": "16",
                             "title_align": "left",
                             "show_legend": true,

diff --git a/ivanti_connect_secure/datadog_checks/ivanti_connect_secure/data/conf.yaml.example b/ivanti_connect_secure/datadog_checks/ivanti_connect_secure/data/conf.yaml.example
@@ -14,7 +14,7 @@
 ## Discover Datadog log collection: https://docs.datadoghq.com/logs/log_collection/
 #
 # logs:
-#   - type: tcp/udp
+#   - type: tcp
 #     port: <PORT>
 #     source: ivanti-connect-secure
 #     service: ivanti-connect-secure