Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-4764] DDS: Ivanti Connect Secure Integration v1.0.0 #19237

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

shubhamvekariya-crest
Copy link
Contributor

What does this PR do?

PR for a new integration Ivanti Connect Secure 1.0.0

Additional Notes
-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behaviour.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@shubhamvekariya-crest shubhamvekariya-crest marked this pull request as ready for review December 10, 2024 11:47
@neko-dd neko-dd added the editorial review Waiting on a more in-depth review from a docs team editor label Dec 10, 2024
@neko-dd
Copy link
Contributor

neko-dd commented Dec 10, 2024

Created DOCS-9701 for Docs team review.

@torosmassa torosmassa changed the title DDS: Ivanti Connect Secure Integration v1.0.0 [AI-4764] DDS: Ivanti Connect Secure Integration v1.0.0 Dec 11, 2024
HadhemiDD
HadhemiDD previously approved these changes Dec 30, 2024
@jhgilbert jhgilbert self-requested a review December 30, 2024 16:10
iliakur
iliakur previously approved these changes Jan 14, 2025
@thibaultkrebs thibaultkrebs added the assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (41957a7) to head (275f49b).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

thibaultkrebs
thibaultkrebs approved these changes Jan 17, 2025
@thibaultkrebs thibaultkrebs self-requested a review January 17, 2025 13:11
@iliakur
Copy link
Contributor

iliakur commented Jan 21, 2025

@shubhamvekariya-crest you can run this command to fix the license headers:

ddev validate license-headers --fix

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed stale reviews from iliakur and HadhemiDD January 22, 2025 05:41

Stale Review dismissed by prbot

@shubhamvekariya-crest
Copy link
Contributor Author

@shubhamvekariya-crest you can run this command to fix the license headers:

ddev validate license-headers --fix

Done, Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent/review-requested assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging docs/review-requested ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor product/review-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants