Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Names for SI_CODEs #875

Merged
merged 24 commits into from
Feb 14, 2025
Merged

[crashtracker] Names for SI_CODEs #875

merged 24 commits into from
Feb 14, 2025

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Feb 12, 2025

What does this PR do?

Adds best effort code to support translating numeric si_code into human readable names.

Motivation

Every different platform has different mappings of numeric codes to meanings. This saves time on the user to figure out what the code actually was.

Additional Notes

This is a best effort code: It currently doesn't handle signals we don't expect to receive. In that case, it soundly says "UNKNOWN".

OSX POSIX support is the worst: https://vorner.github.io/2021/01/03/dark-side-of-posix-apis.html

How to test the change?

Existing additional tests.

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-02-14 20:39:12

Comparing candidate commit 2455871 in PR branch dsn/crashtracker-si-code with baseline commit 4c831d1 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて

  • 🟥 execution_time [+83.646µs; +83.794µs] or [+18.444%; +18.476%]
  • 🟥 throughput [-343909.062op/s; -343297.622op/s] or [-15.597%; -15.569%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.412µs 2.440µs ± 0.018µs 2.438µs ± 0.010µs 2.448µs 2.481µs 2.495µs 2.532µs 3.88% 1.650 4.016 0.73% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.438µs; 2.443µs] or [-0.102%; +0.102%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.891µs 209.134µs ± 0.120µs 209.122µs ± 0.090µs 209.217µs 209.326µs 209.468µs 209.522µs 0.19% 0.366 -0.068 0.06% 0.008µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4772765.961op/s 4781629.757op/s ± 2740.878op/s 4781904.635op/s ± 2057.361op/s 4783788.856op/s 4785680.097op/s 4786652.318op/s 4787176.749op/s 0.11% -0.363 -0.073 0.06% 193.809op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.218µs 18.303µs ± 0.049µs 18.312µs ± 0.032µs 18.335µs 18.374µs 18.404µs 18.418µs 0.58% -0.270 -0.809 0.27% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54295256.693op/s 54636760.245op/s ± 147229.189op/s 54609939.339op/s ± 95764.847op/s 54757696.081op/s 54883470.057op/s 54887057.841op/s 54890362.267op/s 0.51% 0.279 -0.811 0.27% 10410.676op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.668µs 10.728µs ± 0.029µs 10.732µs ± 0.020µs 10.748µs 10.771µs 10.797µs 10.827µs 0.89% 0.126 -0.113 0.27% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 92360835.311op/s 93217375.278op/s ± 251550.389op/s 93179610.920op/s ± 172464.639op/s 93393639.283op/s 93637878.770op/s 93678737.514op/s 93742000.382op/s 0.60% -0.111 -0.139 0.27% 17787.299op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.117µs; 209.150µs] or [-0.008%; +0.008%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4781249.898op/s; 4782009.617op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.296µs; 18.310µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54616355.696op/s; 54657164.795op/s] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.724µs; 10.732µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good throughput [93182512.813op/s; 93252237.742op/s] or [-0.037%; +0.037%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.912ms 5.924ms ± 0.009ms 5.922ms ± 0.003ms 5.926ms 5.934ms 5.971ms 5.978ms 0.94% 3.644 16.199 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.923ms; 5.926ms] or [-0.021%; +0.021%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.279ns 252.993ns ± 10.768ns 248.612ns ± 2.225ns 252.848ns 278.826ns 291.946ns 296.760ns 19.37% 2.422 5.225 4.25% 0.761ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.500ns; 254.485ns] or [-0.590%; +0.590%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 149.702µs 150.808µs ± 0.485µs 150.830µs ± 0.285µs 151.070µs 151.359µs 152.464µs 153.955µs 2.07% 1.614 9.311 0.32% 0.034µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.741µs; 150.875µs] or [-0.045%; +0.045%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.239µs 3.171µs ± 1.397µs 2.983µs ± 0.023µs 3.005µs 3.591µs 9.995µs 17.502µs 486.64% 8.249 72.854 43.94% 0.099µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.978µs; 3.365µs] or [-6.105%; +6.105%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.079µs 33.691µs ± 1.055µs 33.189µs ± 0.058µs 33.345µs 35.949µs 36.055µs 36.824µs 10.95% 1.698 0.974 3.12% 0.075µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.545µs; 33.837µs] or [-0.434%; +0.434%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.893µs 3.914µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.918µs 3.920µs 3.922µs 0.22% -1.739 14.409 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254974903.527op/s 255513283.993op/s ± 185486.198op/s 255526037.989op/s ± 86096.655op/s 255596408.871op/s 255771917.139op/s 255836067.556op/s 256899164.766op/s 0.54% 1.768 14.647 0.07% 13115.855op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.223µs 82.898µs ± 0.706µs 82.945µs ± 0.512µs 83.397µs 84.024µs 84.399µs 84.714µs 2.13% -0.105 -0.416 0.85% 0.050µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11804426.583op/s 12063929.555op/s ± 102845.488op/s 12056129.438op/s ± 74518.017op/s 12138962.870op/s 12238656.828op/s 12291309.544op/s 12311757.517op/s 2.12% 0.145 -0.412 0.85% 7272.274op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 78.374µs 79.451µs ± 0.382µs 79.455µs ± 0.262µs 79.708µs 80.077µs 80.137µs 80.300µs 1.06% -0.114 -0.433 0.48% 0.027µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12453256.164op/s 12586726.224op/s ± 60594.748op/s 12585769.667op/s ± 41549.491op/s 12628282.101op/s 12688759.092op/s 12722257.503op/s 12759312.942op/s 1.38% 0.136 -0.417 0.48% 4284.696op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.896µs 3.914µs ± 0.002µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.920µs 3.921µs 0.18% -2.317 21.838 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255033747.303op/s 255472701.663op/s ± 148832.725op/s 255484504.865op/s ± 71696.824op/s 255546579.760op/s 255625998.078op/s 255723717.453op/s 256700072.841op/s 0.48% 2.349 22.135 0.06% 10524.063op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 75.125µs 76.339µs ± 0.404µs 76.382µs ± 0.248µs 76.628µs 76.925µs 77.127µs 77.140µs 0.99% -0.547 0.141 0.53% 0.029µs 1 200
credit_card/is_card_number/378282246310005 throughput 12963369.250op/s 13099807.680op/s ± 69578.009op/s 13092169.618op/s ± 42483.514op/s 13135089.035op/s 13242132.394op/s 13273805.020op/s 13311126.609op/s 1.67% 0.576 0.183 0.53% 4919.908op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.349µs 51.428µs ± 0.048µs 51.426µs ± 0.018µs 51.441µs 51.473µs 51.526µs 51.815µs 0.76% 4.902 36.799 0.09% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19299390.555op/s 19444865.386op/s ± 17916.706op/s 19445481.675op/s ± 6802.386op/s 19452892.875op/s 19463906.815op/s 19469680.190op/s 19474610.950op/s 0.15% -4.861 36.387 0.09% 1266.902op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.026µs 6.038µs ± 0.007µs 6.037µs ± 0.002µs 6.040µs 6.044µs 6.066µs 6.108µs 1.16% 5.644 46.179 0.12% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163730563.797op/s 165609099.816op/s ± 200310.486op/s 165632779.518op/s ± 65733.142op/s 165685256.828op/s 165812687.933op/s 165891855.024op/s 165937394.378op/s 0.18% -5.585 45.468 0.12% 14164.090op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.914µs ± 0.002µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.918µs 3.922µs 0.21% -2.315 17.707 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254940392.722op/s 255498553.361op/s ± 163362.172op/s 255486870.454op/s ± 88594.302op/s 255576135.580op/s 255727917.679op/s 255854199.849op/s 256778510.652op/s 0.51% 2.343 17.951 0.06% 11551.450op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.889µs 67.145µs ± 0.840µs 67.048µs ± 0.557µs 67.676µs 68.790µs 69.629µs 69.948µs 4.32% 0.756 0.381 1.25% 0.059µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14296298.755op/s 14895431.303op/s ± 184642.285op/s 14914595.530op/s ± 124952.154op/s 15028972.371op/s 15156046.554op/s 15171004.308op/s 15176990.704op/s 1.76% -0.690 0.224 1.24% 13056.181op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.406µs 59.665µs ± 0.103µs 59.680µs ± 0.066µs 59.735µs 59.822µs 59.866µs 59.888µs 0.35% -0.185 -0.681 0.17% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16697796.129op/s 16760380.141op/s ± 28955.064op/s 16756004.673op/s ± 18629.784op/s 16784503.297op/s 16808105.229op/s 16818480.620op/s 16833417.701op/s 0.46% 0.192 -0.679 0.17% 2047.432op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.894µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.917µs 3.919µs 3.920µs 0.17% -2.177 14.508 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255096490.547op/s 255531893.406op/s ± 171711.829op/s 255527545.166op/s ± 88552.604op/s 255611790.094op/s 255776890.182op/s 255953912.526op/s 256812617.819op/s 0.50% 2.201 14.712 0.07% 12141.860op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.219µs 56.785µs ± 0.174µs 56.771µs ± 0.107µs 56.896µs 57.064µs 57.155µs 57.159µs 0.68% -0.186 0.133 0.31% 0.012µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17495123.731op/s 17610429.902op/s ± 53883.320op/s 17614701.231op/s ± 33177.944op/s 17640222.801op/s 17701088.448op/s 17739504.450op/s 17787675.991op/s 0.98% 0.205 0.155 0.31% 3810.126op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.351µs 51.430µs ± 0.034µs 51.428µs ± 0.020µs 51.450µs 51.492µs 51.528µs 51.544µs 0.23% 0.410 0.709 0.07% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19400830.714op/s 19443754.949op/s ± 12876.876op/s 19444530.588op/s ± 7619.884op/s 19451118.852op/s 19464013.473op/s 19470940.149op/s 19473679.375op/s 0.15% -0.404 0.702 0.07% 910.533op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.029µs 6.039µs ± 0.006µs 6.038µs ± 0.002µs 6.040µs 6.046µs 6.049µs 6.106µs 1.12% 7.007 75.248 0.10% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163783234.472op/s 165602494.260op/s ± 164013.202op/s 165618963.382op/s ± 53798.293op/s 165664650.630op/s 165778111.184op/s 165819656.832op/s 165873242.993op/s 0.15% -6.924 74.013 0.10% 11597.485op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255487577.390op/s; 255538990.596op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.800µs; 82.996µs] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12049676.160op/s; 12078182.951op/s] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [79.398µs; 79.504µs] or [-0.067%; +0.067%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12578328.375op/s; 12595124.074op/s] or [-0.067%; +0.067%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.915µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [255452074.879op/s; 255493328.447op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [76.283µs; 76.395µs] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/378282246310005 throughput [13090164.837op/s; 13109450.523op/s] or [-0.074%; +0.074%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.421µs; 51.434µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19442382.303op/s; 19447348.469op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.037µs; 6.039µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/x371413321323331 throughput [165581338.709op/s; 165636860.923op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255475912.935op/s; 255521193.787op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [67.029µs; 67.261µs] or [-0.173%; +0.173%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14869841.658op/s; 14921020.948op/s] or [-0.172%; +0.172%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.650µs; 59.679µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16756367.247op/s; 16764393.034op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255508095.798op/s; 255555691.014op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.761µs; 56.809µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17602962.192op/s; 17617897.612op/s] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.426µs; 51.435µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19441970.337op/s; 19445539.560op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.038µs; 6.039µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165579763.607op/s; 165625224.912op/s] or [-0.014%; +0.014%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 65.530µs 65.759µs ± 0.239µs 65.734µs ± 0.055µs 65.799µs 65.873µs 66.129µs 68.508µs 4.22% 8.945 93.577 0.36% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [65.726µs; 65.792µs] or [-0.050%; +0.050%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.004µs 5.083µs ± 0.040µs 5.094µs ± 0.031µs 5.117µs 5.132µs 5.134µs 5.179µs 1.65% -0.327 -1.290 0.79% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.078µs; 5.089µs] or [-0.110%; +0.110%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 503.995µs 505.798µs ± 0.547µs 505.808µs ± 0.293µs 506.080µs 506.440µs 506.761µs 510.480µs 0.92% 2.758 25.856 0.11% 0.039µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1958942.524op/s 1977074.630op/s ± 2133.445op/s 1977033.461op/s ± 1144.160op/s 1978309.648op/s 1979785.009op/s 1981419.091op/s 1984146.012op/s 0.36% -2.693 25.236 0.11% 150.857op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 536.268µs 537.244µs ± 0.393µs 537.283µs ± 0.265µs 537.499µs 537.810µs 538.288µs 538.340µs 0.20% 0.028 -0.061 0.07% 0.028µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 1857563.286op/s 1861351.833op/s ± 1362.576op/s 1861216.913op/s ± 918.759op/s 1862380.433op/s 1863606.241op/s 1864302.037op/s 1864738.306op/s 0.19% -0.023 -0.064 0.07% 96.349op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 174.791µs 176.106µs ± 0.424µs 176.147µs ± 0.307µs 176.406µs 176.744µs 176.885µs 176.911µs 0.43% -0.338 -0.258 0.24% 0.030µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5652565.217op/s 5678440.286op/s ± 13679.099op/s 5677091.868op/s ± 9882.444op/s 5688075.783op/s 5702161.528op/s 5709902.638op/s 5721108.784op/s 0.78% 0.350 -0.242 0.24% 967.258op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.776µs 37.902µs ± 0.044µs 37.901µs ± 0.030µs 37.933µs 37.977µs 37.997µs 38.022µs 0.32% -0.056 -0.110 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26300337.623op/s 26384015.043op/s ± 30950.608op/s 26384825.601op/s ± 20945.903op/s 26404662.820op/s 26436113.021op/s 26460705.357op/s 26471512.113op/s 0.33% 0.063 -0.108 0.12% 2188.539op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.379µs 48.601µs ± 0.141µs 48.585µs ± 0.046µs 48.633µs 48.764µs 48.841µs 50.200µs 3.32% 7.468 81.785 0.29% 0.010µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19920485.571op/s 20575999.116op/s ± 58312.768op/s 20582530.042op/s ± 19573.457op/s 20600098.424op/s 20627472.251op/s 20654495.570op/s 20670057.496op/s 0.43% -7.228 78.151 0.28% 4123.335op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.723µs; 505.874µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1976778.955op/s; 1977370.305op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [537.190µs; 537.299µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [1861162.993op/s; 1861540.673op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.047µs; 176.164µs] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5676544.494op/s; 5680336.077op/s] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.896µs; 37.908µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26379725.587op/s; 26388304.500op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.581µs; 48.620µs] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20567917.527op/s; 20584080.705op/s] or [-0.039%; +0.039%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.737µs 25.333µs ± 10.741µs 17.925µs ± 0.135µs 34.322µs 42.558µs 54.612µs 94.427µs 426.78% 2.111 8.558 42.29% 0.760µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.844µs; 26.821µs] or [-5.876%; +5.876%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2455871 1739564850 dsn/crashtracker-si-code
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 53.113ms 53.507ms ± 0.254ms 53.384ms ± 0.129ms 53.783ms 53.893ms 54.053ms 54.255ms 1.63% 0.611 -0.979 0.47% 0.018ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [53.471ms; 53.542ms] or [-0.066%; +0.066%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 15.83333% with 101 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (4c831d1) to head (2455871).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   71.67%   71.64%   -0.03%     
==========================================
  Files         324      324              
  Lines       48248    48262      +14     
==========================================
- Hits        34583    34579       -4     
- Misses      13665    13683      +18     
Components Coverage Δ
crashtracker 42.90% <16.96%> (+0.15%) ⬆️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.01% <ø> (ø)
data-pipeline-ffi 90.39% <ø> (ø)
ddcommon 80.08% <ø> (ø)
ddcommon-ffi 61.05% <ø> (ø)
ddtelemetry 61.74% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 90.01% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.68% <ø> (ø)
profiling 80.04% <ø> (ø)
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.57% <ø> (-0.41%) ⬇️
sidecar-ffi 2.05% <ø> (-3.09%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 92.79% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.22% <ø> (ø)

Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Just to reaffirm, the numerical relationship between si_code concepts and values is underdefined at the POSIX level, but needs to be a part of the stable API provided by a platform.

Usually (Linux, at least), if there are changes to this type of thing, it tends to be additive, so the risk factor is missing the naming of an si_code if our build-time kernel version is less than the runtime kernel version. In practice, si_code is not frequently changed.

@danielsn danielsn marked this pull request as ready for review February 14, 2025 15:43
@danielsn danielsn requested review from a team as code owners February 14, 2025 15:43
@danielsn danielsn enabled auto-merge (squash) February 14, 2025 20:04
@danielsn danielsn merged commit a8fb144 into main Feb 14, 2025
31 checks passed
@danielsn danielsn deleted the dsn/crashtracker-si-code branch February 14, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants