Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip serializing parent-id when 0 #879

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Skip serializing parent-id when 0 #879

merged 2 commits into from
Feb 14, 2025

Conversation

VianneyRuhlmann
Copy link
Contributor

What does this PR do?

Skip serializing parent-id when 0. The agent parses it in the same way wether it is defined or not.

Motivation

Dotnet snapshots are expecting the field to not be defined

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@VianneyRuhlmann VianneyRuhlmann requested review from a team as code owners February 13, 2025 15:51
paullegranddc
paullegranddc approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@paullegranddc paullegranddc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VianneyRuhlmann VianneyRuhlmann enabled auto-merge (squash) February 13, 2025 15:57
@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-02-14 13:37:27

Comparing candidate commit 76894d8 in PR branch vianney/skip-serializing-parent-id with baseline commit 7a481f8 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/378282246310005

  • 🟩 execution_time [-9.802µs; -9.534µs] or [-11.409%; -11.097%]
  • 🟩 throughput [+1455976.513op/s; +1494412.188op/s] or [+12.508%; +12.838%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.913µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.918µs 3.920µs 0.15% -2.225 13.525 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255123760.476op/s 255550197.633op/s ± 187976.365op/s 255516497.209op/s ± 96849.022op/s 255623517.364op/s 255861651.823op/s 255936004.048op/s 256943428.717op/s 0.56% 2.249 13.741 0.07% 13291.936op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.066µs 82.562µs ± 0.722µs 82.545µs ± 0.501µs 83.049µs 83.651µs 83.967µs 87.367µs 5.84% 1.444 8.406 0.87% 0.051µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11445957.490op/s 12113011.356op/s ± 104635.094op/s 12114641.536op/s ± 73322.255op/s 12187213.797op/s 12266882.048op/s 12309053.122op/s 12335682.640op/s 1.82% -1.241 6.886 0.86% 7398.818op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 78.238µs 79.481µs ± 0.520µs 79.502µs ± 0.270µs 79.740µs 79.998µs 80.353µs 84.283µs 6.01% 3.766 34.857 0.65% 0.037µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11864794.408op/s 12582213.208op/s ± 80385.367op/s 12578357.846op/s ± 42588.335op/s 12630092.439op/s 12692609.289op/s 12719169.897op/s 12781483.234op/s 1.61% -3.344 30.142 0.64% 5684.104op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.914µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.918µs 3.921µs 3.922µs 0.23% -1.600 16.140 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254941892.997op/s 255508385.327op/s ± 172392.838op/s 255529639.948op/s ± 62511.138op/s 255576078.079op/s 255704602.398op/s 255978695.907op/s 256809598.892op/s 0.50% 1.632 16.371 0.07% 12190.014op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 74.970µs 76.246µs ± 0.445µs 76.262µs ± 0.272µs 76.546µs 76.952µs 77.119µs 77.294µs 1.35% -0.452 0.473 0.58% 0.031µs 1 200
credit_card/is_card_number/378282246310005 throughput 12937537.471op/s 13115878.645op/s ± 76681.335op/s 13112640.402op/s ± 46690.685op/s 13158472.531op/s 13264005.881op/s 13334258.625op/s 13338585.233op/s 1.72% 0.492 0.531 0.58% 5422.189op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.344µs 51.425µs ± 0.032µs 51.424µs ± 0.014µs 51.441µs 51.472µs 51.491µs 51.629µs 0.40% 1.283 8.268 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19368895.818op/s 19445664.383op/s ± 12178.167op/s 19446085.728op/s ± 5191.740op/s 19450395.171op/s 19466275.748op/s 19473656.915op/s 19476299.291op/s 0.16% -1.266 8.170 0.06% 861.126op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.036µs ± 0.004µs 6.036µs ± 0.002µs 6.038µs 6.042µs 6.046µs 6.059µs 0.38% 1.018 5.088 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165038722.845op/s 165662376.658op/s ± 108469.484op/s 165665930.801op/s ± 53680.452op/s 165715465.398op/s 165841398.035op/s 165877886.633op/s 165927868.742op/s 0.16% -1.006 5.025 0.07% 7669.951op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.912µs ± 0.002µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.918µs 3.921µs 0.22% -1.793 14.241 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255032528.865op/s 255600134.822op/s ± 161079.302op/s 255599012.835op/s ± 58611.318op/s 255645132.178op/s 255837238.770op/s 255984959.133op/s 256781048.213op/s 0.46% 1.817 14.419 0.06% 11390.027op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.870µs 66.175µs ± 0.171µs 66.155µs ± 0.105µs 66.264µs 66.451µs 66.588µs 67.087µs 1.41% 1.133 3.274 0.26% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14905962.012op/s 15111550.447op/s ± 38894.102op/s 15115922.217op/s ± 24099.631op/s 15138388.274op/s 15167031.500op/s 15179068.915op/s 15181419.461op/s 0.43% -1.102 3.110 0.26% 2750.228op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.480µs 59.681µs ± 0.089µs 59.681µs ± 0.062µs 59.743µs 59.830µs 59.859µs 59.870µs 0.32% -0.063 -0.583 0.15% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16702781.461op/s 16755778.436op/s ± 24881.208op/s 16755812.423op/s ± 17347.700op/s 16772780.716op/s 16797283.711op/s 16809085.028op/s 16812363.812op/s 0.34% 0.070 -0.582 0.15% 1759.367op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.916µs 3.920µs 3.923µs 0.24% -1.987 18.705 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254932230.515op/s 255552993.413op/s ± 171162.912op/s 255551866.806op/s ± 59161.812op/s 255606211.240op/s 255820677.312op/s 255892523.691op/s 256893019.636op/s 0.52% 2.021 18.962 0.07% 12103.046op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.687µs 57.047µs ± 0.124µs 57.057µs ± 0.088µs 57.141µs 57.220µs 57.251µs 57.262µs 0.36% -0.581 -0.163 0.22% 0.009µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17463727.045op/s 17529555.829op/s ± 38166.923op/s 17526339.425op/s ± 27016.528op/s 17553860.118op/s 17604710.583op/s 17623490.347op/s 17640622.826op/s 0.65% 0.591 -0.145 0.22% 2698.809op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.367µs 51.434µs ± 0.028µs 51.430µs ± 0.014µs 51.448µs 51.481µs 51.529µs 51.567µs 0.27% 1.240 4.520 0.05% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19392405.119op/s 19442282.586op/s ± 10581.170op/s 19444037.145op/s ± 5142.733op/s 19448523.163op/s 19457571.405op/s 19465126.474op/s 19467650.605op/s 0.12% -1.232 4.488 0.05% 748.202op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.038µs ± 0.008µs 6.037µs ± 0.002µs 6.039µs 6.046µs 6.076µs 6.104µs 1.12% 5.003 32.944 0.13% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163819198.640op/s 165614725.334op/s ± 221393.379op/s 165653204.366op/s ± 52121.440op/s 165697594.381op/s 165821169.904op/s 165899287.577op/s 165915169.529op/s 0.16% -4.963 32.527 0.13% 15654.876op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255524145.917op/s; 255576249.349op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.462µs; 82.662µs] or [-0.121%; +0.121%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12098509.939op/s; 12127512.774op/s] or [-0.120%; +0.120%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [79.409µs; 79.553µs] or [-0.091%; +0.091%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12571072.569op/s; 12593353.846op/s] or [-0.089%; +0.089%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255484493.338op/s; 255532277.317op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [76.184µs; 76.308µs] or [-0.081%; +0.081%] None None None
credit_card/is_card_number/378282246310005 throughput [13105251.349op/s; 13126505.940op/s] or [-0.081%; +0.081%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.421µs; 51.430µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19443976.606op/s; 19447352.160op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.036µs; 6.037µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 throughput [165647343.830op/s; 165677409.485op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255577810.780op/s; 255622458.864op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.151µs; 66.199µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15106160.099op/s; 15116940.796op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.669µs; 59.693µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16752330.139op/s; 16759226.732op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255529271.880op/s; 255576714.947op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [57.030µs; 57.064µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17524266.261op/s; 17534845.398op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.430µs; 51.438µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19440816.137op/s; 19443749.034op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.037µs; 6.039µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165584042.341op/s; 165645408.327op/s] or [-0.019%; +0.019%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 503.886µs 505.588µs ± 0.826µs 505.568µs ± 0.292µs 505.836µs 506.258µs 506.464µs 515.376µs 1.94% 8.298 97.054 0.16% 0.058µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1940332.198op/s 1977902.027op/s ± 3187.407op/s 1977974.811op/s ± 1141.865op/s 1979249.385op/s 1981322.219op/s 1981808.325op/s 1984575.657op/s 0.33% -8.151 94.812 0.16% 225.384op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.378µs 453.246µs ± 0.324µs 453.227µs ± 0.200µs 453.450µs 453.802µs 453.939µs 454.349µs 0.25% 0.156 0.267 0.07% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2200949.556op/s 2206310.860op/s ± 1575.503op/s 2206400.127op/s ± 971.387op/s 2207266.094op/s 2208793.665op/s 2209967.208op/s 2210541.475op/s 0.19% -0.152 0.264 0.07% 111.405op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.248µs 176.339µs ± 0.671µs 176.292µs ± 0.229µs 176.536µs 176.795µs 177.232µs 182.206µs 3.35% 6.208 51.551 0.38% 0.047µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5488297.878op/s 5670979.490op/s ± 21091.558op/s 5672399.687op/s ± 7366.345op/s 5678470.395op/s 5692637.429op/s 5699196.862op/s 5706203.186op/s 0.60% -6.037 49.717 0.37% 1491.398op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.595µs 37.693µs ± 0.041µs 37.694µs ± 0.029µs 37.722µs 37.760µs 37.795µs 37.801µs 0.28% 0.177 -0.371 0.11% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26454395.775op/s 26530385.473op/s ± 28863.981op/s 26529640.049op/s ± 20570.359op/s 26551527.720op/s 26576781.314op/s 26590244.286op/s 26599635.585op/s 0.26% -0.172 -0.374 0.11% 2040.992op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.211µs 48.304µs ± 0.041µs 48.298µs ± 0.020µs 48.324µs 48.374µs 48.425µs 48.451µs 0.32% 0.643 1.375 0.08% 0.003µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20639370.161op/s 20702447.853op/s ± 17496.081op/s 20704774.039op/s ± 8719.827op/s 20712390.917op/s 20728820.378op/s 20741610.778op/s 20742349.844op/s 0.18% -0.636 1.361 0.08% 1237.160op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.473µs; 505.702µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1977460.283op/s; 1978343.771op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.201µs; 453.290µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2206092.510op/s; 2206529.209op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.246µs; 176.432µs] or [-0.053%; +0.053%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5668056.403op/s; 5673902.577op/s] or [-0.052%; +0.052%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.687µs; 37.698µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26526385.202op/s; 26534385.743op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.298µs; 48.309µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20700023.064op/s; 20704872.642op/s] or [-0.012%; +0.012%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.687µs 209.037µs ± 0.138µs 209.023µs ± 0.087µs 209.126µs 209.236µs 209.373µs 209.569µs 0.26% 0.521 1.391 0.07% 0.010µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4771702.532op/s 4783854.022op/s ± 3166.389op/s 4784152.336op/s ± 1988.913op/s 4786046.600op/s 4788337.939op/s 4791250.755op/s 4791858.313op/s 0.16% -0.515 1.378 0.07% 223.898op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.255µs 18.319µs ± 0.090µs 18.310µs ± 0.013µs 18.331µs 18.354µs 18.406µs 19.534µs 6.69% 12.341 163.856 0.49% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 51192990.260op/s 54588911.628op/s ± 253295.621op/s 54615277.821op/s ± 39679.179op/s 54648748.618op/s 54730552.522op/s 54749513.141op/s 54781000.292op/s 0.30% -12.138 160.206 0.46% 17910.705op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.670µs 10.731µs ± 0.038µs 10.731µs ± 0.032µs 10.761µs 10.792µs 10.813µs 10.842µs 1.03% 0.333 -0.768 0.35% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 92235213.986op/s 93185228.635op/s ± 327625.795op/s 93187693.395op/s ± 278851.334op/s 93505133.469op/s 93622938.387op/s 93698049.388op/s 93719969.058op/s 0.57% -0.321 -0.788 0.35% 23166.642op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.017µs; 209.056µs] or [-0.009%; +0.009%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4783415.191op/s; 4784292.853op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.307µs; 18.332µs] or [-0.068%; +0.068%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54553807.291op/s; 54624015.965op/s] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.726µs; 10.737µs] or [-0.049%; +0.049%] None None None
normalization/normalize_name/normalize_name/good throughput [93139822.851op/s; 93230634.420op/s] or [-0.049%; +0.049%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 55.258ms 55.507ms ± 0.187ms 55.463ms ± 0.056ms 55.520ms 55.890ms 56.297ms 56.354ms 1.61% 2.631 7.641 0.34% 0.013ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [55.481ms; 55.533ms] or [-0.047%; +0.047%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 245.960ns 254.597ns ± 11.237ns 249.676ns ± 1.920ns 253.673ns 279.404ns 292.688ns 293.641ns 17.61% 2.086 3.491 4.40% 0.795ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.040ns; 256.154ns] or [-0.612%; +0.612%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.984µs 26.090µs ± 11.285µs 18.269µs ± 0.165µs 35.148µs 43.682µs 56.626µs 95.937µs 425.12% 2.098 8.189 43.15% 0.798µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.526µs; 27.654µs] or [-5.995%; +5.995%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.640µs 33.363µs ± 1.116µs 32.842µs ± 0.096µs 33.067µs 35.736µs 35.818µs 36.811µs 12.08% 1.691 0.987 3.34% 0.079µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.208µs; 33.518µs] or [-0.464%; +0.464%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 66.525µs 66.805µs ± 0.219µs 66.811µs ± 0.065µs 66.860µs 66.926µs 67.027µs 69.545µs 4.09% 9.837 120.964 0.33% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [66.775µs; 66.835µs] or [-0.045%; +0.045%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.257µs 3.182µs ± 1.500µs 2.986µs ± 0.022µs 3.006µs 3.598µs 13.825µs 16.750µs 460.93% 7.619 59.331 47.03% 0.106µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.974µs; 3.389µs] or [-6.534%; +6.534%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.411µs 2.429µs ± 0.014µs 2.426µs ± 0.008µs 2.434µs 2.460µs 2.467µs 2.497µs 2.94% 1.384 2.517 0.58% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.427µs; 2.431µs] or [-0.081%; +0.081%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.951ms 5.962ms ± 0.006ms 5.961ms ± 0.003ms 5.964ms 5.968ms 5.979ms 6.013ms 0.88% 4.251 29.212 0.11% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.961ms; 5.963ms] or [-0.015%; +0.015%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 148.659µs 149.809µs ± 0.303µs 149.807µs ± 0.131µs 149.913µs 150.213µs 150.943µs 151.439µs 1.09% 1.467 6.977 0.20% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [149.767µs; 149.851µs] or [-0.028%; +0.028%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 76894d8 1739539560 vianney/skip-serializing-parent-id
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.996µs 5.100µs ± 0.049µs 5.126µs ± 0.024µs 5.141µs 5.150µs 5.153µs 5.173µs 0.91% -0.685 -0.973 0.96% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.093µs; 5.107µs] or [-0.134%; +0.134%] None None None

Baseline

Omitted due to size.

ganeshnj
ganeshnj reviewed Feb 13, 2025
View reviewed changes
trace-utils/src/span_v04/span.rs
@@ -57,6 +57,7 @@ pub struct Span {
pub r#type: BytesString,
pub trace_id: u64,
pub span_id: u64,
#[serde(skip_serializing_if = "is_default")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like we are talking, probably a test case + making it Option<> would be nice.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.66%. Comparing base (7a481f8) to head (76894d8).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   71.66%   71.66%   -0.01%     
==========================================
  Files         324      324              
  Lines       48248    48248              
==========================================
- Hits        34576    34575       -1     
- Misses      13672    13673       +1
Components Coverage Δ
crashtracker 42.71% <ø> (-0.03%) ⬇️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.01% <ø> (ø)
data-pipeline-ffi 90.39% <ø> (ø)
ddcommon 80.08% <ø> (ø)
ddcommon-ffi 61.05% <ø> (ø)
ddtelemetry 61.74% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 90.01% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.68% <ø> (ø)
profiling 80.04% <ø> (ø)
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.97% <ø> (ø)
sidecar-ffi 5.14% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 92.79% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.22% <ø> (ø)

@VianneyRuhlmann VianneyRuhlmann merged commit 4c831d1 into main Feb 14, 2025
31 checks passed
@VianneyRuhlmann VianneyRuhlmann deleted the vianney/skip-serializing-parent-id branch February 14, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshnj ganeshnj ganeshnj left review comments

@paullegranddc paullegranddc paullegranddc approved these changes

Assignees
No one assigned
Labels
mini-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VianneyRuhlmann @codecov-commenter @ganeshnj @paullegranddc