Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send events over UDP #39

Closed
wants to merge 1 commit into from
Closed

Send events over UDP #39

wants to merge 1 commit into from

Conversation

onema
Copy link

@onema onema commented Apr 20, 2016

@hkaj hkaj self-assigned this May 2, 2016
@hkaj
Copy link
Member

hkaj commented May 2, 2016

Thanks a lot @onema! That is an important feature that was missing from this library. We'll review this shortly.

@wvdeutekom
Copy link

Any progress @hkaj?

@ist-pasha
Copy link

This merge would be Pretty Darn Great™ because it also addresses the problem that the current master branch code isn't properly adding the aggregation_key to the event object in the eventUdp() function… Would love to see this merged in.

@hush-hush hush-hush mentioned this pull request Dec 19, 2017
Merged
@hush-hush hush-hush assigned hush-hush and unassigned hkaj Dec 19, 2017
@hush-hush
Copy link
Member

Hi @onema,

Thanks a lot for this PR and sorry it took us so long to come back to it. Since #41 was merged, sending events over UDP was possible.

Yet I updated the code with #48 to support every event fields (based on your PR). This should fix the aggregation_key issue @ist-pasha.

@hush-hush hush-hush closed this Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hush-hush hush-hush

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@onema @hkaj @wvdeutekom @ist-pasha @hush-hush