Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zstd to version 1.4.4 #73

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Update zstd to version 1.4.4 #73

merged 1 commit into from
Nov 6, 2019

Conversation

dbenamydd
Copy link
Contributor

@dbenamydd dbenamydd commented Nov 6, 2019

Synced with something like

git clone https://github.com/facebook/zstd.git c
cd c
git checkout v1.4.4
cd ..
git clone [email protected]:dbenamydd/zstd144.git go
find c/lib \( -name '*.h' -o -name '*.c' \) -exec cp -v {} go/ \;

Copy link
Collaborator

@Viq111 Viq111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Checked that all c and h files were from v1.4.4

Benchmark doesn't show anything too crazy on speed improv (benchmark file was the go binary created).
You can see a slight improvement on decompression speed (~2-3%) as mentioned in the release note but not the 10% announced (maybe the file is too small for it):

ᐅ benchstat ~/old ~/new
name                   old time/op    new time/op    delta
StreamCompression-4      81.5ms ± 7%    82.7ms ± 2%    ~     (p=0.136 n=9+9)
StreamDecompression-4    8.93ms ± 3%    8.63ms ± 2%  -3.40%  (p=0.000 n=10+10)
Compression-4            81.4ms ± 7%    80.9ms ± 8%    ~     (p=0.684 n=10+10)
Decompression-4          7.92ms ± 5%    7.75ms ± 2%  -2.19%  (p=0.017 n=10+9)

name                   old speed      new speed      delta
StreamCompression-4    73.2MB/s ± 7%  72.1MB/s ± 2%    ~     (p=0.136 n=9+9)
StreamDecompression-4   667MB/s ± 2%   691MB/s ± 2%  +3.52%  (p=0.000 n=10+10)
Compression-4          73.3MB/s ± 7%  73.8MB/s ± 8%    ~     (p=0.684 n=10+10)
Decompression-4         753MB/s ± 5%   769MB/s ± 2%  +2.21%  (p=0.017 n=10+9)

@Viq111
Copy link
Collaborator

Viq111 commented Nov 6, 2019

Fixes #72

@Viq111 Viq111 merged commit 8fdb579 into DataDog:1.x Nov 6, 2019
@Viq111 Viq111 mentioned this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants