Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code cleanup #1003

Merged
merged 31 commits into from
Jan 22, 2023
Merged

chore: code cleanup #1003

merged 31 commits into from
Jan 22, 2023

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Jan 2, 2023

Description

Miscellaneous code cleanup.

To do

  • drop use of discard variable
  • consistently use result.Round(n) syntax in unit tests
  • refactor rename test namespaces for consistency
  • use a "Tests" suffix on all unit test classes for consistency
  • refactor rename files for things like .Use and other inconsistencies (e.g. Test.Quote.cs vs Ema.Tests.cs)
  • resolve Codacy analysis findings

@DaveSkender DaveSkender marked this pull request as ready for review January 22, 2023 06:06
@DaveSkender DaveSkender merged commit 2942ab2 into main Jan 22, 2023
@DaveSkender DaveSkender deleted the code-cleanup branch January 22, 2023 06:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant