Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign Marubozu #683

Merged
merged 6 commits into from
Jan 23, 2022
Merged

redesign Marubozu #683

merged 6 commits into from
Jan 23, 2022

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Jan 18, 2022

Description

Based on feedback from users (see #220), making some updates that will serve as a baseline approach for future candlestick pattern indicators.

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender DaveSkender marked this pull request as ready for review January 23, 2022 05:40
@DaveSkender DaveSkender enabled auto-merge (squash) January 23, 2022 06:05
@DaveSkender DaveSkender merged commit 8a3a623 into main Jan 23, 2022
@DaveSkender DaveSkender deleted the marubozu-feedback branch January 23, 2022 06:06
@github-actions
Copy link

This Pull Request has been automatically locked since there has not been any recent activity after it was closed. Please open a new Issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant