Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no reversal case for PSAR #758

Merged
merged 1 commit into from
Mar 27, 2022
Merged

fix: no reversal case for PSAR #758

merged 1 commit into from
Mar 27, 2022

Conversation

DaveSkender
Copy link
Owner

Description

The first leg of PSAR persisted when insufficient quote history was provided to produce any pivot reversals. Normally it is excluded. This fixes that inconsistency so it does not return a repainted trendline if no reversals are present.

Fixes #743

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender DaveSkender merged commit bf1e7cd into main Mar 27, 2022
@DaveSkender DaveSkender deleted the psar-warmup branch March 27, 2022 22:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSAR first leg persists and is repainting
1 participant