Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade misc utilities #985

Merged
merged 12 commits into from
Dec 28, 2022
Merged

upgrade misc utilities #985

merged 12 commits into from
Dec 28, 2022

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Dec 25, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation, context, and sources of information or recipes.

Unblocks #983 and implements:

Breaking changes ⚠️

  • IQuote.Date should be replaced by ISeries.Date if you have a customized (renamed) quote date property
  • .ToTupleCollection(NullTo.Null2NaN) was replaced by a simpler .ToTupleNaN()

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender DaveSkender changed the title refactor reorganize + add ISeries upgrade SyncIndex Dec 25, 2022
@DaveSkender DaveSkender changed the title upgrade SyncIndex upgrade misc utilities Dec 25, 2022
@DaveSkender DaveSkender marked this pull request as ready for review December 27, 2022 23:25
@DaveSkender DaveSkender enabled auto-merge (squash) December 28, 2022 01:17
@DaveSkender DaveSkender merged commit c8fd6ed into main Dec 28, 2022
@DaveSkender DaveSkender deleted the syncopy branch December 28, 2022 01:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2023
@DaveSkender
Copy link
Owner Author

This was implemented in v2.4.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant