Request Review Notification Update to Usernames

[hblankenship]

[sc-2890]

This update displays the [user fullname (username)] for both the reviewer and the reviewees.

[dryrunsecurity]

DryRun Security Summary

The pull request enhances the functionality of the dojo/finding/views.py file in the DefectDojo application by modifying the reviewers_string variable to include the user ID of each reviewer and including the user's full name and ID in the description parameter of the create_notification function call, which improves transparency and enhances the overall user experience.

Expand for full summary

Summary:

The code changes in this pull request are focused on enhancing the functionality of the dojo/finding/views.py file, which manages the findings in the DefectDojo application. The key changes include:

1. Modifying the reviewers_string variable to include the user ID of each reviewer, in addition to their name. This change provides more context about the reviewers when a finding review is requested.

2. Including the user's full name and ID in the description parameter of the create_notification function call. This provides more detailed information about who requested the review.

From an application security perspective, these changes do not introduce any obvious security risks. The code is focused on improving the user experience and providing more transparency around the review process, which can be beneficial for auditing and tracking purposes. Overall, the changes seem to be a positive step in enhancing the security-related functionality of the DefectDojo application.

Files Changed:

• dojo/finding/views.py: This file contains the logic for managing findings in the DefectDojo application. The changes in this pull request include:
  • Modifying the reviewers_string variable to include the user ID of each reviewer, in addition to their name.
  • Including the user's full name and ID in the description parameter of the create_notification function call.
    These changes are focused on providing more detailed information about the review process, which can improve transparency and enhance the overall user experience.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[mtesauro]

Approved