Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reported Finding Severity by Month on the dashboard to be by month instead of day. #11304

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

hblankenship
Copy link
Collaborator

[sc-8650]

Addresses #11254

The graph on the dashboard for "Reported Finding Severity by Month" is currently displaying data in days, rather than months. And when there is only 1 data point (all findings are from the same day as it was in the demo case in the issue above) then the graph does not display correctly.

This changes the minimum data point to 1 and specifies that the data is by month. This should display accurate, if not visually appealing, data when there is only 1 month's worth of data. As time progresses, the chart will look better and will display up to 6 months of Reported Finding Severity by Month.

@github-actions github-actions bot added the ui label Nov 21, 2024
Copy link

DryRun Security Summary

The code changes in this pull request are related to the homepage_severity_plot function in the metrics.js file, where the minTickSize property of the xaxis configuration is set to [1, "month"] to ensure the x-axis of the plot displays the time in monthly intervals, and this change does not directly introduce any security vulnerabilities.

Expand for full summary

Summary:

The code changes in this pull request are related to the homepage_severity_plot function in the metrics.js file. The primary change is to set the minTickSize property of the xaxis configuration to [1, "month"], which ensures that the x-axis of the plot will display the time in monthly intervals, rather than the default behavior which may result in a more granular time scale.

From an application security perspective, this change does not directly introduce any security vulnerabilities. The metrics.js file appears to be responsible for rendering various data visualization charts and graphs related to application metrics, such as the number of issues or vulnerabilities over time. The change to the minTickSize property is likely a UI/UX improvement to make the chart more readable and understandable for the users. However, it's important to review the overall context of this file and the application it belongs to, as well as any other related code changes, to ensure that there are no potential security implications, such as the display of sensitive information.

Files Changed:

  • dojo/static/dojo/js/metrics.js: The code changes in this file are related to the homepage_severity_plot function, specifically setting the minTickSize property of the xaxis configuration to [1, "month"]. This change ensures that the x-axis of the plot will display the time in monthly intervals, rather than the default behavior which may result in a more granular time scale. From a security perspective, this change does not directly introduce any vulnerabilities, but it's important to review the overall context of the file and the application to ensure there are no potential security implications.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit dd85ea3 into bugfix Dec 3, 2024
74 checks passed
@Maffooch Maffooch deleted the hb-severity-by-month-dash-fix branch December 3, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants