Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs maintenance: remove external images, article updates #11341

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

paulOsinski
Copy link
Contributor

@paulOsinski paulOsinski commented Nov 27, 2024

This PR is intended to move externally hosted images into the main repo, along with the following docs updates:

  • Add Universal Importer / Dojo-CLI docs
  • update DefectDojo Pro Changelog
  • replace all externally hosted (on Intercom) images with images on the repo, and update all image refs to use those hosted images
  • rework Request A Trial article with updated language

[sc-8918]
[sc-9103]

Copy link

dryrunsecurity bot commented Nov 27, 2024

DryRun Security Summary

The provided input does not contain any code changes or files to review, so the application security engineer cannot provide a meaningful summary or analysis.

Expand for full summary

Summary:

There are no code changes provided in the input, so I do not have any specific observations or recommendations to make. As an application security engineer, I would typically review any code changes in a pull request to ensure they do not introduce any security vulnerabilities or unintended consequences. However, without any changes to review, I cannot provide a meaningful summary or analysis.

Files Changed:

There are no files changed in the provided input.

Code Analysis

We ran 9 analyzers against 30 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@github-actions github-actions bot added the docs label Nov 27, 2024
@paulOsinski paulOsinski changed the title Docs images docs maintenance: remove external images, article updates Nov 27, 2024
@paulOsinski paulOsinski changed the title docs maintenance: remove external images, article updates Docs maintenance: remove external images, article updates Nov 27, 2024
@mtesauro
Copy link
Contributor

Follow on to #11258

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@paulOsinski
Copy link
Contributor Author

some of these filenames were going to break Windows builds as per issue: #11366

I have fixed those references but I imagine I will have to rebase once this hotfix is accepted: #11368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants