add system setting to enable/disable audit logging #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentijnscholten
added
performance
madchap
approved these changes
Mar 16, 2020
Maffooch
added
the
New Migration
Maffooch
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in #2065 , the audit logging is a severe bottleneck during (re-)imports.
this PR adds a system setting to enable/disable audit logging. in some situations users/admin might prefer speedy import over audit logs.
the audit log UI was removed from the admin portal anyway, so I doubt lots of people are using it.
log entries can still be viewed though in the 'View History' menu item for Products, Findings, etc.
the default is still to have audit logging enabled.