[node] stream: support readable/writableHWM for Duplex

[everhardt]

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:

• nodejs/node@ef8ac7b
• https://nodejs.org/api/stream.html#stream_new_stream_duplex_options

• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[everhardt]

Travis CI failed on not being able to find an npm log file, which I cannot reproduce locally. I assume its a Travis (config) bug, so I'll retry building it by closing and reopening this pull request.

[typescript-bot]

@everhardt Thank you for submitting this PR!

🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @BrunoScheufler @smac89 @tellnes @Touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @octo-sniffle @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @ZaneHannanAU @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @jeremiergz - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[r3nya]

It would be awesome if you add some tests. Thanks in advance.

[everhardt]

again: an Azure pipeline failed on not being able to find an npm lock file, which I cannot reproduce locally. I assume its a (config) bug, so I'll retry building it by closing and reopening this pull request.

[everhardt]

I give up on getting the checks to succeed: still getting an error about a lock file that I think has nothing to do with this pull. Please review it anyway

[typescript-bot]

@everhardt The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[galkin]

@everhardt, thank you for your pull. There is my review. Could you make changes?

[typescript-bot]

@everhardt One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

node/v12

Comparison details for node/v12 📊

	master	#40843	diff
Batch compilation
Memory usage (MiB)	124.3	124.7	+0.3%
Type count	21725	21725	0%
Assignability cache size	39465	39465	0%
Language service
Samples taken	1871	1871	0%
Identifiers in tests	11757	11761	0%
getCompletionsAtPosition
Mean duration (ms)	716.9	708.8	-1.1%
Mean CV	6.8%	6.7%
Worst duration (ms)	1003.4	964.2	-3.9%
Worst identifier	timers	sock
getQuickInfoAtPosition
Mean duration (ms)	708.0	699.4	-1.2%
Mean CV	6.5%	6.5%	+0.6%
Worst duration (ms)	942.5	936.1	-0.7%
Worst identifier	setMulticastLoopback	searchParams

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

node/v10

Comparison details for node/v10 📊

	master	#40843	diff
Batch compilation
Memory usage (MiB)	120.2	120.9	+0.6%
Type count	18104	18106	0%
Assignability cache size	34683	34683	0%
Language service
Samples taken	5121	5291	+3%
Identifiers in tests	10200	10204	0%
getCompletionsAtPosition
Mean duration (ms)	700.1	678.8	-3.0%
Mean CV	0.0%	0.0%
Worst duration (ms)	1482.1	1460.7	-1.4%
Worst identifier	close	inspector
getQuickInfoAtPosition
Mean duration (ms)	703.2	679.2	-3.4%
Mean CV	0.0%	0.0%
Worst duration (ms)	1307.0	1304.0	-0.2%
Worst identifier	inspectorUrl	inspector

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

🔔 @galkin - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

[galkin]

@everhardt, thank you for your work.

[typescript-bot]

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

[orta]

Alright, looks like additions only and has a few +1s - merging

[typescript-bot]

I just published @types/[email protected] to npm.

[typescript-bot]

I just published @types/[email protected] to npm.