Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at #318
Couple of points before reviewing:
ArrayBuffer
sinceIterable
andIterator
are not JS types and I didn't feel comfortable adding them to theType
enumIntoJsIter
since it's not really anInto
trait like we generally see in rust, but it's similar in spirit toIntoJsFunc
IntoJsIter
are a bit strange with theposition
. I use theposition
in my util crate https://github.com/DelSkayn/rquickjs/pull/319/files#diff-653c6889323b6067b2be818f8ff00f785927ae3beaaeaba4a034feb5ea154d4eR133 since I do some magic with theThis
to access the parent class to avoid copying the values and my function is stateless so I need some indication on where we are. But we might want to remove it from the trait and move it toIterFn
andIterFnMut