Skip to content

Commit

Permalink
download debootstrap using HTTPS
Browse files Browse the repository at this point in the history
RE: security issue with a dead simple fix: download debootstrap using HTTPS - originally by @eighthav - [issue 2067](dnschneid#2067)

Right now, crouton downloads debootstrap from anonscm.debian.org using an HTTP link. That URL is also accessible using an HTTPS link, e.g.
  • Loading branch information
DennisLfromGA committed Sep 17, 2015
1 parent edbce11 commit 9c3c5fd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions installer/ubuntu/bootstrap
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@

# Grab the latest release of debootstrap
echo 'Downloading latest debootstrap...' 1>&2
d='http://anonscm.debian.org/gitweb/?p=d-i/debootstrap.git;a=snapshot;h=HEAD;sf=tgz'
d='https://anonscm.debian.org/gitweb/?p=d-i/debootstrap.git;a=snapshot;h=HEAD;sf=tgz'
if ! wget -O- --no-verbose --timeout=60 -t2 "$d" \
| tar -C "$tmp" --strip-components=1 -zx 2>/dev/null; then
echo 'Download from Debian gitweb failed. Trying latest release...' 1>&2
d='http://httpredir.debian.org/debian/pool/main/d/debootstrap/'
d='https://httpredir.debian.org/debian/pool/main/d/debootstrap/'
f="`wget -O- --no-verbose --timeout=60 -t2 "$d" \
| sed -ne 's ^.*\(debootstrap_[0-9.]*.tar.gz\).*$ \1 p' \
| tail -n 1`"
Expand Down

1 comment on commit 9c3c5fd

@DennisLfromGA
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IGNORE PLEASE - Got overzealous with https - my bad...

Please sign in to comment.