feat: Docusaurus3 #467
Merged
feat: Docusaurus3 #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rob-odwyer
reviewed
Nov 6, 2023
| @@ -325,6 +355,8 @@ const config = { | |||
| 'yaml', | |||
| 'csharp', | |||
| 'dart', | |||
| // Leave php disabled until this issue is fixed upstream: https://github.com/PrismJS/prism/issues/2769 | |||
| //'php' | |||
There was a problem hiding this comment.
I noticed that the Python examples don't seem to be getting syntax highlighting either. They do on docs.devcycle.com though, even though it doesn't seem to have been in this list to begin with. Any idea what's happening there?
There was a problem hiding this comment.
hmm - i'll add it to the list and see what happens. Python only recently got support
rob-odwyer
approved these changes
Nov 6, 2023
gerhard
added a commit
to slumbering/dagger
that referenced
this pull request
Nov 23, 2023
Not sure why we are not using the Docusaurus file, but have our own: https://github.com/facebook/docusaurus/blob/8dc24b6a98968f585af1bb5e6f8b7a1fcae0d7d4/packages/docusaurus-theme-classic/src/theme/prism-include-languages.ts#L31 PrismJS/prism#2769 was helpful. DevCycleHQ/devcycle-docs#467 was a good reference. Signed-off-by: Gerhard Lazu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to DS3
<>characters