Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean properties in json file are inconsistent #46

Closed
rjwills28 opened this issue Jan 23, 2024 · 1 comment
Closed

Boolean properties in json file are inconsistent #46

rjwills28 opened this issue Jan 23, 2024 · 1 comment

Comments

@rjwills28
Copy link
Collaborator

As noticed in #44, in the json file the scroll and executeAsOne properties take a boolean value, whereas showCloseButton takes a boolean wrapped as a string, i.e.

"scroll": true,
"executeAsOne": false,
"showCloseButton": "true"

I think these should be consistent as it is easy to make a mistake and use the wrong type when creating the json file. Presumably showCloseButton should just be a boolean.
abigailalexander added a commit that referenced this issue Jan 24, 2024
@abigailalexander
Fix Issue #46
d5b221f
@rjwills28 rjwills28 mentioned this issue Jan 26, 2024
Open
abigailalexander added a commit that referenced this issue Jan 29, 2024
@abigailalexander
Merge pull request #48 from dls-controls/fix-json-boolean-prop
4d40c6f 
Fix Issue #46
@abigailalexander
Copy link
Collaborator

Fixed by PR #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjwills28 @abigailalexander