Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seperate columns for From and To fields; show Date and Time #7

Closed
wants to merge 2 commits into from

Conversation

schoerg
Copy link

@schoerg schoerg commented Nov 9, 2018

I found it more useful to see both From and To fields in the message list.

Both ToShortDateString and ToShortTimeString are used to keep locale.
@schoerg
Copy link
Author

schoerg commented Nov 9, 2018

Second commit got merged with this: show date and time

@schoerg schoerg changed the title Add seperate columns for From and To fields Add seperate columns for From and To fields; show Date and Time Nov 9, 2018
@Dijji
Copy link
Owner

Dijji commented Nov 10, 2018

Hi

Your code is very good, and certainly of the right quality to merge. However, I don’t agree with the proposed changes, and here’s why.

My intent was to follow the Outlook defaults precedent. Given limited space, Outlook shows either From or To for each email, depending whether it has been received or sent. For time, it shows time-of-day for very recent emails, day of the week for emails received this week, and otherwise the short date. I emulated this by showing either From or To, in the same way, and simplified the time by just showing the short date for everything.

Of course, a full email client would let you configure what properties were shown, but given that that is beyond my scope, I still think that I am in about the right place in following the Outlook precedent. Also, given that the source is open, developers at least can do what you have done and change things to suit themselves.

So I am currently proposing not to merge these changes, but please feel free to tell me why I am wrong.

Dijji

@schoerg
Copy link
Author

schoerg commented Nov 11, 2018

Hi,

Some background: I recently had a relative ask me to retrieve some (presumably lost) mails from his harddrive. I then found your tool, but his mail archive had a lot of forwarded? or BCC? mails inside them. Stuff like where the person is neither in From nor To field. So this helped him and me to find the mails he wanted. As the mails where somewhat older (2017 and beyond) I haven't noticed the date behaviour as you described.

These changes where a mere quality of life improvement for me. I can understand why you don't want to merge this. Just wanted your thoughts on this - maybe someone else will find this useful.

@Dijji
Copy link
Owner

Dijji commented Nov 12, 2018

Your scenario is very valid, though. Perhaps what I should do is to again follow the Outlook example and show the additional information (date/time, from or to, whichever was not shown, plus the copy and blind copy lists) in a variable height panel above the body of the selected email.

Would that have helped you?

Dijji

@schoerg
Copy link
Author

schoerg commented Nov 13, 2018

Probably not, but I can't say for sure now. I haven't checked much of the content of the mails. I don't use Outlook, so I had no idea that you tried to follow their style.

@flywire
Copy link
Contributor

flywire commented Dec 8, 2019

@schoerg re 01729f3 - done at 1090d3f

@Dijji
Copy link
Owner

Dijji commented Dec 8, 2019

As flywire notes, displaying both date and time has now made it into master, after some further discussion, as has showing Outlook style header information above the contents of the email, and the ability to search through email headers (including cc and bcc) .

I still don't agree with separate From and To columns, though. It would consume more space, and in most cases, the only information added would be my own name, which I should already know.

Thank you again for your input. It is through suggestions and constructive discussion that programs improve.

Dijji

@Dijji Dijji closed this Dec 8, 2019
Dijji added a commit that referenced this pull request Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants