fix: drop shell for lint #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misaka-0x447f
previously approved these changes
Sep 13, 2019
scripts/lint.js
Outdated
| [ | ||
| // Guess what happens if you don't do this? | ||
| // Path resolution makes a \n, which becomes... | ||
| path.join(base, 'node_modules/eslint/bin/eslint.js'), |
There was a problem hiding this comment.
This could be a problem in case of using pnpm.
There was a problem hiding this comment.
What about require.resolve('eslint') or something?
There was a problem hiding this comment.
pnpm will not break because both are explicit dependencies.
There was a problem hiding this comment.
doing a resolve sounds good but is pointless -- they are never going to resolve into global deps or the installation is broken. and if they are not global does they are going to be exactly there because they are explicitly listed as deps.
There was a problem hiding this comment.
reasonable. but hard code a path is little hack with me
There was a problem hiding this comment.
aghflaljdgajdlaj
|
Now use eslint api to lint. |
Jack-Works
previously approved these changes
Sep 16, 2019
SunriseFox
previously approved these changes
Sep 16, 2019
we can node it ourselves; triggered by nodejs/node#29532
SunriseFox
dismissed stale reviews from Jack-Works and themself
via
4ed0445
SunriseFox
force-pushed
the
fix/no-path-bs
branch
from
a49b394
to
4ed0445
Compare
SunriseFox
approved these changes
Sep 16, 2019
Jack-Works
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
shellbreaks filenames with ampersands.we can node it ourselves; triggered by nodejs/node#29532