-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise CSS Grid #338
Merged
Merged
Optimise CSS Grid #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These optimizations make sense to me. Do we have benchmarks for grid yet? |
No, I was about to make some. But I got distracted doing the yoga ones 😂 |
nicoburns
force-pushed
the
grid/optimise
branch
5 times, most recently
from
January 27, 2023 01:27
33a7e88
to
a26f6ad
Compare
…nown_dimension computation
…her than available_grid_space
…on<f32> instead of AvailableSpace
nicoburns
force-pushed
the
grid/optimise
branch
from
January 27, 2023 14:19
0dc71ed
to
a630b04
Compare
nicoburns
force-pushed
the
grid/optimise
branch
from
January 29, 2023 14:27
f054cb5
to
e9e8a6a
Compare
I'm happy to see this merged when you think it's ready :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This targets a couple of obvious optisations of the grid algorithm:
It also updates the grid code to use
inner_node_size
(Size<f32>
) rather thanavailable_grid_space
(Size<f32>
) asinner_node_size
should always be used for resolving percentages.