Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: baseline alignment support #344

Merged
merged 10 commits into from
Feb 3, 2023

Conversation

nicoburns
Copy link
Collaborator

Objective

Support baseline alignment in the CSS Grid Algorithm.

This implements both:

  • Computing the first baseline of a grid container
  • Baseline aligning items within grid rows

There is plenty more that could be supported such as vertical baselines and last baselines. But this brings us up to parity with what is implemented for flexbox.

@nicoburns nicoburns mentioned this pull request Jan 30, 2023
87 tasks
@nicoburns nicoburns added this to the 0.3 "CSS Grid" milestone Jan 30, 2023
Copy link
Collaborator

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear and well-tested, like usual.

@alice-i-cecile alice-i-cecile enabled auto-merge (squash) February 3, 2023 01:06
@alice-i-cecile alice-i-cecile added the enhancement New feature or request label Feb 3, 2023
@nicoburns nicoburns force-pushed the grid/baseline-alignment branch from f8fc967 to 4d30d0d Compare February 3, 2023 01:26
@alice-i-cecile alice-i-cecile merged commit ab747b8 into DioxusLabs:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants