-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for guild time outs. #161
Add support for guild time outs. #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Made some initial comments, mostly documentation-related.
Member._update
also needs to handle the new value, to keep the member cache consistent with the current state.
One change I'd like to propose is to change the (relatively long) name of communication_disabled_until
to something like guild_timeout
or just timeout
, similar to the abstraction of rate_limit_per_user
behind slowmode_delay
; perhaps others can pitch in regarding this idea.
Co-authored-by: shiftinv <[email protected]>
Done. 27a0241
Hmm, sounds good to me, I would go with Also, regarding the name, I created a poll in the Discord server. So I'm going to wait until it gets some votes. |
Update: it should be ready for review right now. |
It got auto-imported, my bad.
Okay so, the PR should be ready for review, but I think it's worth to wait until it's released, basically to avoid possibly breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just have a few more suggestions.
And yea, this shouldn't be merged before the feature is rolled out to more servers/users.
Co-authored-by: shiftinv <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of weird formatting going on due to the stupidly long variable name but we probs won't be able to do much about that.
Summary
Discord has been experimenting with guild time outs lately, so I decided to try to implement it.
A few hours ago they added a new permission to add timeouts, so I guess this will actually be implemented.
TODO:
Guild.timeout(...)
?new permission reference:
Discord-Datamining/Discord-Datamining@35cb2c6
Checklist
black .