feat(GuildIterator): fill approximate_member_count and approximate_presence_count fields when fetching Guilds

[Victorsitou]

Summary

Guilds fetched with Client.fetch_guilds now have approximate_member_count and approximate_presence_count fields filled.

discord/discord-api-docs#5628

Checklist

• If code changes were made, then they have been tested
  • I have updated the documentation to reflect the changes
  • I have formatted the code properly by running task lint
  • I have type-checked the code by running task pyright
• This PR fixes an issue
• This PR adds something new (e.g. new method or parameters)
• This PR is a breaking change (e.g. methods or parameters removed/renamed)
• This PR is not a code change (e.g. documentation, README, ...)

[Skelmis]

I can't think of the use case for this param, but all other parameters to this HTTP method can be passed when this method is used in iterators. Shouldn't with_counts also be specified as an option within GuildIterator

[Victorsitou]

I can't think of the use case for this param, but all other parameters to this HTTP method can be passed when this method is used in iterators. Shouldn't with_counts also be specified as an option within GuildIterator

If I remember correctly, we decided to keep it always as True.

[Skelmis]

I can't think of the use case for this param, but all other parameters to this HTTP method can be passed when this method is used in iterators. Shouldn't with_counts also be specified as an option within GuildIterator

If I remember correctly, we decided to keep it always as True.

I see, thanks.

[shiftinv]

@Skelmis brings up a valid point though. I don't think there are situations where you don't want this to be set to True, but it also wouldn't hurt to make it configurable for fetch_guild and fetch_guilds just in case.

[shiftinv]

the API docs PR for this got merged, could you update this one as discussed above?

[Victorsitou]

Done. 6046af9

[shiftinv]

lgtm, thanks!

[shiftinv]

oops, noticed one more thing

[Victorsitou]

oops